lh-ehr
lh-ehr copied to clipboard
Notification icon showing notifications even after reading the notifications
A) My Outreachy username : faiqa
B) Issue Title : Notification icon showing notifications even after reading the notifications
C) Bug Report Date : March 5, 2019
D) Site Affected : Documentation Site.
E) OS/Browser Used : Windows/Chrome.
F) Workflow Module/Tab : Message and Reminder Center.
G) Step to reproduce :
- Login with your account credentials.
- Take your cursor to the notifications icon in the top right corner.
- Click on the icon.
- Message and Reminder Center tab will open.
H) Expected Behavior : When we click on notification icon it should display the notified message/notification and the numbering on the icon should gone.
I) What actually Happened : When I clicked on notification icon it showed the notified message but numbering on icon remains the same.
J) ScreenShot :
K) Estimation of the bug severity : Module function continues with ongoing errors
@FaiqaShafqat79 triggering a change of status in the database once this read will do the job. I think for now if you change from read to done and reload the page you shouldn't see the notification count increment again. so that is a quick walk around - i.e turning it to the done function once the message is opened
Yeah it's a quick walk around if we trigger a change of status in database
On Tue, Mar 5, 2019 at 11:47 PM muarachmann [email protected] wrote:
@FaiqaShafqat79 https://github.com/FaiqaShafqat79 triggering a change of status in the database once this read will do the job. I think for now if you change from read to done and reload the page you shouldn't see the notification count increment again. so that is a quick walk around - i.e turning it to the done function once the message is opened
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/lh-ehr/issues/1414#issuecomment-469810492, or mute the thread https://github.com/notifications/unsubscribe-auth/AjigVqgg2eJGWBg1OsaKqM6J7CXbB35iks5vTru5gaJpZM4bdn_c .
It is a nice tweak to do. Better yet, find two places it can be used, and write a standard library for page reload arguments.