lh-ehr icon indicating copy to clipboard operation
lh-ehr copied to clipboard

Next / Previous buttons on Patient Finder do not change display

Open tusharjindal100 opened this issue 5 years ago • 11 comments

A) My Outreachy username : Jindal_Tushar

B) Issue Title : Next / Previous buttons on Patient Finder do not change display

C) Bug Report Date : 27 FEB 2019

D) Site Affected : Documentation Site.

E) OS/Browser Used : MacOS/Chrome

F) Module/Tab : Patient Finder

G) Step to reproduce: 1. Login with your account credentials. 2. Take your cursor to Patient/Client tab then you see the Finder.Click on it.
3. You will see Previous and Next button at the bottom of the tab. 4. Click on the Next/Previous button.

H) Expected Behavior : Next/Previous buttons should change the display in Patient Finder. If one screen shows 10 results of patients then Next button should show the next 10 results on the screen and Previous button should show the previous 10 results.

I) What actually Happened : I am not able to click Next/Previous Button on Patient Finder.

J) ScreenShots: Patient Finder

image

K) Estimation of the bug severity: Work with Workaround

L) Workaround: For Developers :- Div of the Orange(Refresh) button below the Previous/Next Button is so large that it is covering the Previous/Next button. We can decrease the size of the Div. I am attaching the Chrome Inspector so that it would be easy to solve this bug.

image

For Users/Healthcare professional:- For accessing the button, Make sure that the Patient Finder tab is presented on the left side of screen with at least one tab is opened at the right of it. (See the screenshot below)

image

tusharjindal100 avatar Mar 01 '19 05:03 tusharjindal100

I notice that the documentation site (from your screenshots) has the updater icon on, and I am not sure about the theme. These are factors that may affect this. My instances all work. Then again, I don't use less than a 1080p screen, and there can be scaling issues affecting the use case. This needs to get hardened in any case. Please request assignment to fix this issue.

aethelwulffe avatar Mar 01 '19 16:03 aethelwulffe

Thank you. This was found and reported by our Outreachy EHR Coder Intern Candidate. Is it possible to request a dev to help the candidate learn to fix it?

KoniKodes avatar Mar 01 '19 16:03 KoniKodes

I believe it is due to the documentation site's settings (bad theme), but I will try to replicate the issue more closely so that I may advise the candidate @tusharjindal100 (welcome aboard!).

aethelwulffe avatar Mar 01 '19 17:03 aethelwulffe

Thank you so much!

KoniKodes avatar Mar 01 '19 18:03 KoniKodes

@aethelwulffe i will get rid of the updater icon if you want and let the outreach applicant do the fix. I kinna wanted a newbie to fix this here #1400 @KoniKodes i am available if any. I love the way the stuff is explained maybe i should build some template for reporting issues after outreachy's round

muarachmann avatar Mar 02 '19 02:03 muarachmann

Thank you @muarachmann If it is approved, I know my applicant would appreciate it.

@htuck created the Report Template, I just added a couple of thoughts after everything else was in place. I'm sure he won't mind sharing if you ask nicely, it's all for the same EHR team.

Yes, I will be calling on you for guidance.

KoniKodes avatar Mar 02 '19 02:03 KoniKodes

@KoniKodes like i said i have the next and prev stuffs working. The issue should rather be removing the updater that blocks #1400 or something similar take a look i have 51-100 entries i am looking at right now when i press next

screen shot 2019-03-08 at 6 16 37 pm

muarachmann avatar Mar 08 '19 17:03 muarachmann

@tusharjindal100 are you still on this ?

muarachmann avatar Mar 08 '19 17:03 muarachmann

He is currently in the hospital. We are sending best wishes that he can join us soon.

If he's not back in time, will you work with the chosen intern to fix this?

Otherwise you can work together when he returns.

KoniKodes avatar Mar 08 '19 21:03 KoniKodes

@muarachmann I am back.Pleade tell me what to do about this.Will be more than happy to contribute

tusharjindal100 avatar Mar 12 '19 00:03 tusharjindal100

Glad to hear you are feeling better.

I can navigate the button. and get patients. Can you verify that too?

On Mon, Mar 11, 2019 at 8:41 PM tusharjindal100 [email protected] wrote:

@muarachmann https://github.com/muarachmann I am back.Pleade tell me what to do about this.Will be more than happy to contribute

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/lh-ehr/issues/1412#issuecomment-471798460, or mute the thread https://github.com/notifications/unsubscribe-auth/APl-XsA2WazivpU5vPyBcn2iTp4UkiFWks5vVvehgaJpZM4bYUdr .

muarachmann avatar Mar 12 '19 00:03 muarachmann