lh-ehr icon indicating copy to clipboard operation
lh-ehr copied to clipboard

Updater position blocks pagination

Open muarachmann opened this issue 5 years ago • 12 comments

The current position of the updater icon may lead to problems while paginating in the future. This calls for discussion. Your ideas are needed to solve this. Take a look at patients pagination one cant go to the next page

screen shot 2019-02-02 at 05 45 29

muarachmann avatar Feb 02 '19 04:02 muarachmann

Updater icon is not really a good "on by default" item. Should just be a Administration menu item. The menu could turn the button on and off visible as a user preference, but better to just have a "hide" option on the button, with a notice that you must re-enable in user prefs, or launch from the Administration menu. It is dangerous to have it on top of in-use reports and lots of other things. It interferes with the billing manager and several other things as well..

aethelwulffe avatar Feb 04 '19 17:02 aethelwulffe

I agree with Art - the demos are a good example -- I don't want people updating it...we don't even have the it installed as a git repo -- we use git but rsync everything over. On 2/4/19 12:10 PM, Art Eaton wrote:

Updater icon is not really a good "on by default" item. Should just be a Administration menu item. The menu could turn the button on and off visible as a user preference, but better to just have a "hide" option on the button, with a notice that you must re-enable in user prefs, or launch from the Administration menu. It is dangerous to have it on top of in-use reports and lots of other things. It interferes with the billing manager and several other things as well..

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/lh-ehr/issues/1400#issuecomment-460330380, or mute the thread https://github.com/notifications/unsubscribe-auth/AABaMEoefQOA02JOnmbY6IdQFLaT6O33ks5vKGmggaJpZM4afaxt.

robbyoconnor avatar Feb 04 '19 18:02 robbyoconnor

Hidden feature.... ON with  "DEV" install type, but not just banging around with the default install.  "Lite" them should also be changed from default and dumped as well.  Too many things are goofy with lite.

On 2019-02-04 13:21, robbyoconnor wrote:

I agree with Art - the demos are a good example -- I don't want people updating it...we don't even have the it installed as a git repo -- we use git but rsync everything over. On 2/4/19 12:10 PM, Art Eaton wrote:

Updater icon is not really a good "on by default" item. Should just be a Administration menu item. The menu could turn the button on and off visible as a user preference, but better to just have a "hide" option on the button, with a notice that you must re-enable in user prefs, or launch from the Administration menu. It is dangerous to have it on top of in-use reports and lots of other things. It interferes with the billing manager and several other things as well..

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub

https://github.com/LibreHealthIO/lh-ehr/issues/1400#issuecomment-460330380,

or mute the thread

https://github.com/notifications/unsubscribe-auth/AABaMEoefQOA02JOnmbY6IdQFLaT6O33ks5vKGmggaJpZM4afaxt.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/lh-ehr/issues/1400#issuecomment-460355810, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhzF3iHKgxQwevaPXvdlA7bpVkyr2cxks5vKHosgaJpZM4afaxt.

aethelwulffe avatar Feb 04 '19 18:02 aethelwulffe

Hidden feature.... ON with  "DEV" install type, but not just banging around with the default install.  "Lite" them should also be changed from default and dumped as well.  Too many things are goofy with lite.

This should be server-side as well -- not changeable in the install install itself. I don't want people turning it on in the demo.

robbyoconnor avatar Feb 04 '19 23:02 robbyoconnor

Demo is a demo, and we should not in the least be deploying or configuring anything in the product intended for clinics that base their entire operations on the product simply for the sake of a demo.  Yes, we want the upgrade feature easily discoverable, and have a config setting in the demo database that disables it.  For demos, that means that you MUST configure it as a demo, and not have the default install be what makes the LH.io demo happiest.

On 2019-02-04 18:00, robbyoconnor wrote:

Hidden feature.... ON with  "DEV" install type, but not just
banging around with the default install.  "Lite" them should also
be changed from default and dumped as well.  Too many things are
goofy with lite.

This should be server-side as well. Not in the install itself. I don't want people turning it on in the demo.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/lh-ehr/issues/1400#issuecomment-460447861, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhzF3-XmqGDk_Xu26TLMY-syJtY7CTkks5vKLuGgaJpZM4afaxt.

aethelwulffe avatar Feb 05 '19 17:02 aethelwulffe

ok @aethelwulffe so we get this feature under the admin menu right (under preferences) or some sort of turn of an off feature in the globals. If yes this issue is open for anyone to work on.

muarachmann avatar Feb 06 '19 11:02 muarachmann

Yes

aethelwulffe avatar Feb 06 '19 15:02 aethelwulffe

Okay i will prefer someone take a peek at this

muarachmann avatar Feb 06 '19 15:02 muarachmann

@muarachmann So ill prefer you hint me more about what is it that needs to be done. Is it just going to be the positioning of the icon or more about the functioning??

tafodinho avatar Feb 10 '19 20:02 tafodinho

the functionalities are already there. Its just for you to place the updater in a suitable position. First check if user is admin to display this option under the admin menu. down forget the developers mode too and settings menu. Find a way to incorporate it. Also consider putting this in the Administration > globals where it can be turned off and on but should be on by default. Please also look at previous comments

muarachmann avatar Feb 10 '19 21:02 muarachmann

Looking at where the updater button is positioned right now I think that is the best position. I am just going to focus on turning the button on and off in the Administration > globals > appearance

tafodinho avatar Feb 11 '19 07:02 tafodinho

No @tafodinho look at the issue description it should not be there. Please read the issue comments

muarachmann avatar Feb 11 '19 07:02 muarachmann