lh-ehr icon indicating copy to clipboard operation
lh-ehr copied to clipboard

Admin/Facility/(click to edit) goofy UI

Open aethelwulffe opened this issue 5 years ago • 10 comments

image Screenshot from NHANS, normal demo dev-tip down, and looks even worse on my server!

aethelwulffe avatar Jan 18 '19 19:01 aethelwulffe

@aethelwulffe izimodal has options for width, height and fullscreen options. This can be exploited here. Let me know if there is something to do about this and i will file in a PR.

muarachmann avatar Jan 20 '19 22:01 muarachmann

Here is my screen on light

screen shot 2019-01-21 at 7 30 01 am

Here on prism

screen shot 2019-01-21 at 7 34 28 am

muarachmann avatar Jan 21 '19 06:01 muarachmann

Not here. Test on a 1080p screen maybe? Look at the NHANS demo. Same on all my servers and local machine.

aethelwulffe avatar Jan 22 '19 16:01 aethelwulffe

Nothing in the logs as an error.

aethelwulffe avatar Jan 22 '19 16:01 aethelwulffe

Ah. Try renaming the default facility, then add a second facility.

aethelwulffe avatar Jan 22 '19 16:01 aethelwulffe

After that, look again.

aethelwulffe avatar Jan 22 '19 16:01 aethelwulffe

Always test data with a big data set...lesson learned again.

aethelwulffe avatar Jan 22 '19 16:01 aethelwulffe

I will try then re-sizing my screen to get the behaviour. Thanks for taking out time to review and leave some comments. Love to have you guys around to poke a little :)

On Tue, Jan 22, 2019 at 5:07 PM Art Eaton [email protected] wrote:

Always test data with a big data set...lesson learned again.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/lh-ehr/issues/1387#issuecomment-456456256, or mute the thread https://github.com/notifications/unsubscribe-auth/APl-Xo9nu71yPPdHgrFQbYFcgXHISLnJks5vFzcqgaJpZM4aIfBb .

muarachmann avatar Jan 22 '19 16:01 muarachmann

Add and edit some facilities. I was not able to get a clean interface by doing any resizing or tab adjustments.

aethelwulffe avatar Jan 22 '19 16:01 aethelwulffe

@muarachmann @teryhill @muarachmann Here is my "twelve merges in 9 hours" integration test site: "demouser" and "Testing lots of stuff."

The URL is https://samwise.suncoastconnection.com:3443/libre_ehr/interface/login/login.php?site=2019JAN22MERGEs Mua, please look at the edit facility before I change anything else. Totally fresh install.

My results are with Firefox specifically.

aethelwulffe avatar Jan 22 '19 22:01 aethelwulffe