Selecting Procedure in Batch Results Opens Up Inappropriate Module

[jonathanzhang53]

Important Note

This will require you to test locally to fully understand (unless I just wrote such a great description). The issue is not really a clear code fix.

Description

When you try to see batch results for a certain procedure, selecting a procedure leads to a list of Types of Orders and Results which you can select, but clicking save does not do anything and does not select the procedure. I have tried different combinations of interactions but there's no way to actually select a procedure.

Reproduce

Login to EHR locally. Create a procedure if one is not yet created by going to Procedures > Configuration and adding a top level (the easiest to fill out is a group type procedure). Go to Procedures > Batch Results. Click the procedures input box to reveal a popup module. Click save or add or anything else but a procedure still isn't selected for the input

Fix

The popup has the functionality of Procedures > Configuration but that is not what is needed in this case. All that is needed is a list of the orders and the ability to select one and confirm selection.

GIF

Again, I recommend going on your own demo to test this.

[robbyoconnor]

Not 100% sure these labels -- someone can fix them...just trying to triage things for GCI metric purposes.

[jonathanzhang53]

@robbyoconnor I'm not going to approach this for GCI. I just found it and I wanted to report it.

[aethelwulffe]

@tmccormi @teryhill Where are we with this particular form? Does any of it also relate to LIMS? This isn't something we are looking to deprecate or anything is it? I don't use the system at all, so I don't know much about it.

[mshubhankar]

I'm a new contributor and am finding my first issue to work on. This seems like a good start. What is exactly expected ?

These are my observations

• The cancel button needs to be fixed.
• The save button needs to close the window instead of popping it back up again.
• The add for each row opens up procedures->configurations module which needs to be removed and instead the ability to select a row needs to be added.

Have I got it correctly ?

[jonathanzhang53]

@mshubhankar When I encountered this issue, I discovered that the module that opened up was not at all what was supposed to be there. It's not a functionality issue of any of the components, but the whole popup is not correlative with the function of the page I was on.

If you want to investigate further, reproduce the steps to get to the screen and try to understand what is supposed to be accomplished through the popup. Currently, the popup is a duplicate of Procedures > Configuration, which it should not. The functionality should simply be to select a procedure and proceed.

[mshubhankar]

Is something like this required ? I have removed the Add button and added a functionality for rows to be selected.

[jonathanzhang53]

That should be fine, as long as a config can be selected and the data is passed through correctly. Maybe some more experienced collaborators can shed light on the online chat (chat.librehealth.io).