lh-ehr
lh-ehr copied to clipboard
LibreHealthIO
Theme Design for EHR
@teryhill , @Trodrige , @tmccormi , @aethelwulffe . I am opening this issue to discuss on the EHR current theming.
- First, we dont have a standard theme, like an eye catching stuff,
- Secondly a theme should be consistent through out the software which is not the case with EHR. Some times, the nav bar as an underline, another time at the extreme end has some coloring, (special case with purple and prism) themes.
- Also the areas need to be distinguished as to where the css properties applies.
Like for example main body have a color, navbar have a color, , tabs panel have a color etc,
From what i see in globals is this i see primary color and secondary color.
It should be clear where these colours apply, is this on the navbar, main body or tab body. Some colours overlap etc.
To this effect, i would like to know if we can design a general theme and allow end users manipulate just as the initial idea. This will help greatly for future contributions. Cause now people are tempted in doing inline css and adding extra classes just to suite some cases which eventually turns up in a poor UI when switching from theme to theme.
IMO, we agree on the buttons padding, margin and headers title etc so theme looks uniform. All this can be achieved with bootstrap which is currently in the code base.
@bauripalash the issue is not upgrade to bootstrap , we have bootstrap in the codebase but it is not even used often. We need first a sketch of how our theme is to look like then from there we can know what css stuff to better use
From my experience, certain classes seem to be very troublesome to deal with, namely button classes and some text colors. I think this has been mentioned somewhere, but I think starting from one theme and benching the others is a good idea, and then getting the theme to where it needs to be for the whole site and then making some function that allows color changes only. CSS is all over the place :P
I think the best way to do this is to create a doc defining the various components of the theme and how they’ll look like. This way others contribute their own ideas and we reach a final theme which we’ll build. On Fri, Dec 28, 2018 at 7:32 PM Jonathan Zhang [email protected] wrote:
From my experience, certain classes seem to be very troublesome to deal with, namely button classes and some text colors. I think this has been mentioned somewhere, but I think starting from one theme and benching the others is a good idea, and then getting the theme to where it needs to be for the whole site and then making some function that allows color changes only. CSS is all over the place :P
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/lh-ehr/issues/1357#issuecomment-450406091, or mute the thread https://github.com/notifications/unsubscribe-auth/APZj20WTZ2CAF_uYSZJTHlLpJGCMDaHfks5u9mPIgaJpZM4ZJ1uj .
-- Tigpezeghe R. K.
So how would this proceed? I'm pretty down to help /w this. Do we need permission to start or something 😛
@jonathanzhang53 By all means Start. The goal would be to have a Maximum of 2 themes, remove all in line css, allow users to change colors.
Ok with a max of two themes, I think we should just get the ideas down on a doc, and then see if there are multiple diverging preferences for styling, if not then one theme.
google doc share link we can start here, unless there is some other documentation already existent for the themes ^^^
Also there were some UI fixes made during GCI, I'm not sure if those were just for GCI task's sake or if they will actually be merged. But if they are going to be merged, that should be done and then css changes should be capped so the theme doesn't run into any conflict with new changes and does not outdate old changes.
I have a commit I'm working on right now about some UI, and I'll try to finish that up.
If we want to cap theme and UI tweaks, I am all for it. We need to work on existing PR's related to that, then declare a moratorium...with a project plan. We will also need a "Theme Czar" to oversee that as a project and to actively hunt down and oversee anyone popping up with a contribution related.
I was planning an efficient way of doing this for GSoC Art. I have already some mockups and sketches. Not forgetting to polish up the setup improvement. Let me know the way foward.
On Tue, Jan 22, 2019 at 5:18 PM Art Eaton [email protected] wrote:
If we want to cap theme and UI tweaks, I am all for it. We need to work on existing PR's related to that, then declare a moratorium...with a project plan. We will also need a "Theme Czar" to oversee that as a project and to actively hunt down and oversee anyone popping up with a contribution related.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LibreHealthIO/lh-ehr/issues/1357#issuecomment-456461091, or mute the thread https://github.com/notifications/unsubscribe-auth/APl-Xv5dbSaNZmm943bYTLBrVxIjxvqAks5vFznsgaJpZM4ZJ1uj .
I like the idea of making a single actual "theme" and maybe the two stored (default and other) configurations of that theme...to be chosen on install.
If you can build that into your proposal, that would be great.
Okay. I have got this. More on this would be discussed either in the forums or chats when i am done with the normal sketch up on A4s. I want to handle it on papers first , then on sketchup , before seeing its implementation and how to proceed