lh-ehr icon indicating copy to clipboard operation
lh-ehr copied to clipboard

GSoC 2018 : Calendar Improvements-Repeat parameters in Calendar Admin

Open apooravc opened this issue 6 years ago • 9 comments

Fixes #767

Repeat parameters are added in Calendar Admin so that a set of repeat parameters settings can be stored with respect to an existing category or new category and can be accessed as default settings of repeat parameters corresponding to the selected category in patient or provider event panel.

Preview: rp

Work done:

  1. Added repeat parameters in calendar admin (admin.php) as they were in event panel (add_edit_event.php).
  2. Made some changes in admin.php and admin_helper.php so that they store and display settings as selected by user corresponding to a category in table libreehr_postcalendar_categories.
  3. Made some changes in add_edit_event.php and appointments.inc.php so that event panel displays default settings in repeat parameters (from table libreehr_postcalendar_categories) corresponding to a selected category in case of a new event. If it is an existing event, repeat parameters settings will be displayed according to table libreehr_postcalendar_events, which is already the case.

@teryhill Please have a look.

apooravc avatar Jul 06 '18 16:07 apooravc

@teryhill Added a few things to fix some issues. Expected behavior:

  1. In case of new events, set recurring parameters according to values set in admin upon opening of event panel (default category) or when category changes.
  2. In case of existing events, set recurring parameters according to values set in table libreehr_postcalendar_events upon opening of event panel (selected category) which is already the case but set recurring parameters according to values set in admin when category changes.

apooravc avatar Jul 19 '18 22:07 apooravc

@tmccormi can you see if this is the way you want this to work?

teryhill avatar Jul 20 '18 00:07 teryhill

OK. Looked at this, and it seems to:

  1. Work without crashing.
  2. Solve the use-case outlined by htuck.

aethelwulffe avatar Jul 31 '18 18:07 aethelwulffe

@aethelwulffe added license headers in last commit.

apooravc avatar Aug 01 '18 00:08 apooravc

I have not been looking at the attribution on files lately. Ooops. Good catch. -Folks, this is ready for further review.

aethelwulffe avatar Aug 03 '18 17:08 aethelwulffe

@tmccormi Please have a look.

apooravc avatar Aug 11 '18 16:08 apooravc

@teryhill @tmccormi @Trodrige @pri2si17-1997 @Perseus and everyone else. Please check this.

aethelwulffe avatar Aug 28 '18 01:08 aethelwulffe

Fixed conflicts. Second test by someone else please!

aethelwulffe avatar May 09 '19 14:05 aethelwulffe

Apparently there is an issue here.

aethelwulffe avatar May 09 '19 14:05 aethelwulffe