service.libreelec.settings icon indicating copy to clipboard operation
service.libreelec.settings copied to clipboard

Published 20 hours ago • verified publisher icon LibreELEC

Shutdown crash

Open ysard opened this issue 4 years ago • 5 comments

Hi, I propose 2 fixes on this PR.

  • First and basically a workaround regarding a regular Kodi crash due to the Dbus Connection Object that does not seem to be deleted correctly.

This has been exposed in this issue (LibreELEC/LibreELEC.tv#5645) but there, no action has been taken so far.

The bbc7bf3 commit of the PR #240 has not solved the problem on my side.

  • Secondly, by cleanliness a fix of anecdotal typo.

Thank you for reading

ysard avatar Nov 04 '21 01:11 ysard

I added some minor cleaning of code; now it's finished for me.

ysard avatar Nov 06 '21 17:11 ysard

Looks like the dbussy author replied to the other thread and made changes already.

chewitt avatar Nov 07 '21 06:11 chewitt

I read it, the del is still needed but not the collection anymore. Still investigating...

ysard avatar Nov 09 '21 16:11 ysard

I think that the problem is closed on the dbussy side. I added current debugging logs on the issue LibreELEC/LibreELEC.tv#5645.

I can remove the call to garbage collector since it is not used anymore. I can also clean the commit history (via push force) of this issue if you prefer. Nevertheless it will be necessary to wait for a new version of dbussy on pypi for this code to be compatible.

ysard avatar Nov 11 '21 04:11 ysard

Nevertheless it will be necessary to wait for a new version of dbussy on pypi for this code to be compatible.

we bumped dbussy (https://github.com/LibreELEC/LibreELEC.tv/pull/5945) so it should work now ?

CvH avatar Dec 05 '21 06:12 CvH