Fix chrome-downloader

[notkudu]

The link provided in this script doesn't work anymore, so I fixed the link and also using current instead of a version number, this ensure the latest version of chrome

I tried it on my TV and it worked perfectly.

[CvH]

the current link https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_121.0.6167.85-1_amd64.deb still works here

btw you switch to just stable that means nobody knows what version it is and will very likely break in future (due missing libs etc)

[notkudu]

so I deleted chrome and re-downloaded it to reset everything and I am getting this error with the default script

LibreELEC:~/.kodi/addons/browser.chrome/bin # chrome-start Downloading Chrome Traceback (most recent call last): File "/storage/.kodi/addons/browser.chrome/bin/deb_extract_data", line 15, in <module> ar = unix_ar.open(sys.argv[1]) ^^^^^^^^^^^^^^^^^^^^^^^^^ File "/storage/.kodi/addons/browser.chrome/resources/unix_ar.py", line 373, in open return ArFile(_open(file, omode), mode) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/storage/.kodi/addons/browser.chrome/resources/unix_ar.py", line 152, in __init__ self._read_entries() File "/storage/.kodi/addons/browser.chrome/resources/unix_ar.py", line 160, in _read_entries raise ValueError("Invalid archive signature") ValueError: Invalid archive signature mv: can't rename 'opt/google/chrome': No such file or directory chmod: /storage/.kodi/addons/browser.chrome/chrome-bin/chrome: No such file or directory chmod: /storage/.kodi/addons/browser.chrome/chrome-bin/chrome-sandbox: No such file or directory /storage/.kodi/addons/browser.chrome/bin/chrome-start: line 96: /storage/.kodi/addons/browser.chrome/chrome-bin/chrome: not found

and when I change the link it does work fine.

[antonlacon]

I'm closing because the proposed code change won't be taken. As mentioned, we do not want chrome's version changing without our knowing.

Given chrome is a popular addon, and there aren't other reports of being unable to download, my suspicion is the problem is on your end. You can troubleshoot this by looking at bin/chrome-downloader for the steps it's taking to download chrome. The command at the heart of it (as of this comment) is curl -# -O -C - https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/ google-chrome-stable_123.0.6312.122-1_amd64.deb.

The error you shared is bin/deb_extract_data trying to open an archive that either doesn't exist, or isn't an archive (ValueError: Invalid archive signature).

If you're looking for a project, improving the error messaging/logging in bin/chrome-downloader and bin/deb_extract_data would be beneficial. deb_extract_data should confirm the file exists before trying to open it.