LibreELEC.tv icon indicating copy to clipboard operation
LibreELEC.tv copied to clipboard

u-boot: Prevent /usr/include/libfdt_env.h from being included

Open catalinii opened this issue 2 years ago • 4 comments

u-boot compilation for arm64 seems to fail due to existing /usr/include/libfdt_env.h which re-defines few of the types defined in this file. The define in the patch prevents that file from being included.

catalinii avatar Jun 16 '22 17:06 catalinii

@catalinii Please fix the commit message to follow house style, e.g. "package: description of change" and send the patch to the upstream u-boot mailing list for review and hopefully merge by maintainers. We strongly prefer to backport patches that can be dropped in a future u-boot package bump.

chewitt avatar Jun 17 '22 06:06 chewitt

@chewitt thanks for reviewing.

My understanding is that the u-boot for rockchip boards uses an old commit from rockchip repository and not the upstream u-boot project. I tried upgrading the u-boot to the latest comming in next branch but that is a different task in itself

catalinii avatar Jun 17 '22 16:06 catalinii

@chewitt can you review again please?

catalinii avatar Jun 24 '22 03:06 catalinii

ping @chewitt

catalinii avatar Jul 29 '22 23:07 catalinii

@CvH can you please review ?

catalinii avatar Aug 16 '22 17:08 catalinii

^^^^^ @chewitt @jernejsk @knaerzche anyone an idea ?

CvH avatar Sep 11 '22 09:09 CvH

No clue, and the author never bothered to reformat the commit message so it's not mergeable anyway. I'd rather see the work @knaerzche is doing to bump RK devices to mainline u-boot suceed and be the focus.

chewitt avatar Sep 11 '22 09:09 chewitt

@chewitt I formated the message according to your suggestion "package: description of change"

Please let me know what is missing.

Thanks

catalinii avatar Sep 12 '22 16:09 catalinii

you didn't follow the format told by @chewitt in commit subject.

Anyway, this PR is basically obsolete, because #6885 will drop this code when it's merged (likely soon)

jernejsk avatar Sep 12 '22 16:09 jernejsk

closed because superseded by https://github.com/LibreELEC/LibreELEC.tv/pull/6885

CvH avatar Sep 13 '22 10:09 CvH