LibreELEC.tv
LibreELEC.tv copied to clipboard
u-boot: Prevent /usr/include/libfdt_env.h from being included
u-boot compilation for arm64 seems to fail due to existing /usr/include/libfdt_env.h which re-defines few of the types defined in this file. The define in the patch prevents that file from being included.
@catalinii Please fix the commit message to follow house style, e.g. "package: description of change" and send the patch to the upstream u-boot mailing list for review and hopefully merge by maintainers. We strongly prefer to backport patches that can be dropped in a future u-boot package bump.
@chewitt thanks for reviewing.
My understanding is that the u-boot for rockchip boards uses an old commit from rockchip repository and not the upstream u-boot project. I tried upgrading the u-boot to the latest comming in next branch but that is a different task in itself
@chewitt can you review again please?
ping @chewitt
@CvH can you please review ?
^^^^^ @chewitt @jernejsk @knaerzche anyone an idea ?
No clue, and the author never bothered to reformat the commit message so it's not mergeable anyway. I'd rather see the work @knaerzche is doing to bump RK devices to mainline u-boot suceed and be the focus.
@chewitt I formated the message according to your suggestion "package: description of change"
Please let me know what is missing.
Thanks
you didn't follow the format told by @chewitt in commit subject.
Anyway, this PR is basically obsolete, because #6885 will drop this code when it's merged (likely soon)
closed because superseded by https://github.com/LibreELEC/LibreELEC.tv/pull/6885