chrome: improvements to the python launch script

[pohutukawa]

chrome: improvements to the python launch script

• improved exception reporting to the logger
• improved subprocess handling to be more pythonic
• fixed compatibility with configuration for custom audio devices (ALSA) to be compatible with previous custom settings
• fixed launchability of Chrome in presence of custom audio device config (that were working previously)
• slight simplifications for more pythonic code in some functions

[pohutukawa]

Also created a PR for the backport to the libreelec-10.0 branch in PR #6009

[pohutukawa]

Sorry for the delay, but I've been on a camping holiday and recently got back. It's hot and summery here ... :-)

I've incorporated the suggested change from above.

[mglae]

Thanks. Unfortunately this PR needs a rebase to current master and revision 112 already exist.

Edit: please squash your commits.

[pohutukawa]

What package version should it be, then? 112 or 113? (As the libreelec-10.0 doesn't have a 112, yet, so my worry is that they won't be in sync). Dang, I wish I had gotten this sorted out before the holiday :-)

[chewitt]

The master and libreelec-10.0 branches are not in-sync to start with (each contains different overall content) so there is no need for the PRs to be in-sync. Just update the master branch PR to the next available number.

[pohutukawa]

done. I just don't know how/what those two conflicts above are coming from, as I guess they should be part of the PR on the change. Sorry for being such a nuisance ... :-(

[mglae]

You have directly edited and pushed the master branch. It cannot updated any more following the usual workflow. Fortunately the local and remote branch name can be different.

To clean up your local master branch environment use (untested):

# Create a backup. Just in case.
git branch -c master le11_chrome_backup_220127

# Create the new working branch
git branch -c master le11_chrome_improvements

# Reset and update local master branch to LE master
git checkout master
git fetch upstream
git reset --hard upstream/master

# Rebase working branch
git checkout le11_chrome_improvements
git rebase -i master

# When all done force push the working branch to the existing PR
git push -f origin le11_chrome_improvements:master

Similar has to be done for the backport but let's start with master.

[heitbaum]

Work incorporated into

• #7101
• #7310