LibreELEC.tv icon indicating copy to clipboard operation
LibreELEC.tv copied to clipboard

[BUG] LE settings addon causes crashes when switching profiles

Open HiassofT opened this issue 4 years ago • 14 comments

Describe the bug

When switching profiles, eg from master user to a separate profile, kodi crashes if LE settings addon is included in system image.

The issue was originally reported on the forum https://forum.libreelec.tv/thread/23657-le-10-0b1-crash-after-profile-change/

To Reproduce

  1. Clean LE installation, accept defaults in wizard
  2. Create one (or two) profiles in settings->profiles, accept defaults, enable "Show login screen on startup"
  3. reboot LE
  4. select master profile in login screen
  5. log out of master profile
  6. select first created profile in login screen
  7. kodi crashes

Informations

  • LE Version: LE 10b1, master
  • Hardware Platform: RPi4, forum users also reported Generic

Log file

Kodi crash log: http://ix.io/2Vrs

Additional context

The crash log points to python's _asyncio.so lib which indicates the crash is probably caused by the LE settings addon.

Building an image without LE settings addon results in working profile switching without crashes.

Log file from switching between master and both test profiles back and forth several times: http://ix.io/2Vrv

HiassofT avatar Apr 08 '21 23:04 HiassofT

Can you enable LE settings add-on debugging and post another log please?

lrusak avatar Apr 08 '21 23:04 lrusak

Here's a log with DEBUG=1 in kodi.conf: http://ix.io/2Vt3

HiassofT avatar Apr 09 '21 08:04 HiassofT

it's a long shot but can you test this patch? https://termbin.com/y454

lrusak avatar Apr 09 '21 15:04 lrusak

the patch didn't help - kodi is still crashing http://ix.io/2VwX

HiassofT avatar Apr 09 '21 19:04 HiassofT

Does it crash if you disable/enable the add-on?

lrusak avatar Apr 09 '21 19:04 lrusak

enabling/disabling isn't possible in kodi, probably because it's flagged as a system addon

screenshot00000

HiassofT avatar Apr 09 '21 20:04 HiassofT

If I disable Bluetooth (Settings -> Services), I can switch profiles at will.

antonlacon avatar May 11 '21 21:05 antonlacon

If I disable Bluetooth (Settings -> Services), I can switch profiles at will.

Not in my case. Still crashing.

EDIT: I'm on LE 10b2 x86 generic.

Grandma-Betty avatar May 18 '21 07:05 Grandma-Betty

Still crashing on LE 10b3, x86 generic.

Grandma-Betty avatar May 21 '21 06:05 Grandma-Betty

Multiple profiles support in Kodi is broken for some time and should be removed if someone finds time to do it.

romanvm avatar Jun 16 '21 20:06 romanvm

Multiple profiles support in Kodi is broken for some time and should be removed if someone finds time to do it.

What do you mean it's broken in Kodi? I have several Kodi 19.1 installations which are all running fine with multiple profiles. It's just crashing in LibreELEC, not in Kodi. I heard of that the whole code has to be rewritten beause it's ugly code. Don't get me wrong but just because the code is bad doesn't mean it's broken? It would be too sad if multiple profiles were removed, this is the main reason I am using Kodi/LibreELEC because that way I can manage all of my familiy members individually and keep kids away from things that do not belong to them.

Grandma-Betty avatar Jun 18 '21 06:06 Grandma-Betty

FYI: latest nightly is still crashing with the same _asyncio.so backtrace http://ix.io/3utf

HiassofT avatar Jul 30 '21 10:07 HiassofT

just a warning, looks like nobody is looking into the issue so LE10 final will have this broken

CvH avatar Aug 01 '21 19:08 CvH

#5724 #5725

heitbaum avatar Oct 08 '21 19:10 heitbaum

@HiassofT - is this still an issue. Did the asyncio changes in python address or partially address it?

heitbaum avatar Sep 06 '23 08:09 heitbaum

Looks like we just forgot to close the issue. Tested with LE master, profile logoff/logon works fine

HiassofT avatar Sep 07 '23 17:09 HiassofT