libredwg icon indicating copy to clipboard operation
libredwg copied to clipboard

Improve flags_r11 setting in preR13 encoding

Open michal-josef-spacek opened this issue 1 year ago • 2 comments

I am going to improve flags_r11 setting. I created PR https://github.com/LibreDWG/libredwg/pull/757 which:

  • Describe these numbers precisely
  • Added flags_r11 from the structure if is defined

One thing is TODO, which I am not able to set now:

  • Add dwg->header.section[id].flags_r11 = __FROM_CONTROL__ in https://github.com/LibreDWG/libredwg/blob/master/src/in_json.c#L3264 It helps conversions from JSON to DWG and better ability to test conversion from DWG to JSON and back.

michal-josef-spacek avatar Jun 07 '23 23:06 michal-josef-spacek

This comment TODO: maybe add a missing CONTROL object here. GH #453 is something else. We do store all the CONTROL objects plus its flags_r11 in the json already.

But we need your new function for indxf

rurban avatar Jun 08 '23 06:06 rurban

@rurban In JSON, yes, but conversion from JSON to DWG is not working (e.g. in the case of flags_r11)

michal-josef-spacek avatar Jun 08 '23 07:06 michal-josef-spacek