memmem issue on Apple's 10.6 SDK (was: Package the code to vcpkg)

[msclock]

Can we package the code to vcpkg?

• vcpkg
• package a lib

Are there any guidelines or permits I should follow？

[rurban]

Sure you can. See the various cmake or mingw autotools recipes.

[msclock]

I have submit a pr to vcpkg. https://github.com/microsoft/vcpkg/pull/30005.

This is the usage: https://github.com/msclock/vcpkg/blob/bfa07fd074023fe0b4eb835363d280c80256572e/ports/libredwg/usage#L1-L4

All scripts I configured are based on the cmake build system.

I came across a configuration item that needed to be lowered.

• memmem could be checked by cmake but it reports an error on Apple, so the my_memmem option is opened by replacing defined(COMMON_TEST_C) with a true condition all the time. https://github.com/msclock/vcpkg/blob/bfa07fd074023fe0b4eb835363d280c80256572e/ports/libredwg/portfile.cmake#L37-L46

[rurban]

The memmem issue on Apple's 10.6 SDK is already handled by the 2nd case in common.h, just the declaration is missing. There I assume HAVE_MEMMEM is 1, but the decl in string.h is missing.

[msclock]

The memmem issue on Apple's 10.6 SDK is already handled by the 2nd case in common.h, just the declaration is missing. There I assume HAVE_MEMMEM is 1, but the decl in string.h is missing.

Well, it is. HAVE_MEMMEM was evalated as 1 but it reports implicitly decl error. The assumption is not valid so that I have to set an eternal true condition on Apple.

[rurban]

So I'll try to come up with a better fix

[rurban]

I've added now a vcpkg.json

[msclock]

@rurban Got it. I've noticed that with the current quick iteration, maybe we can create our own registry for quick iterative updates, and then push it to the official VCPKG registry when it stabilizes. Please refer to:

• create registry, and refer to the example.
• using registry, and refer to example.

I will create a pr implement it a bit later.

[rurban]

msclock @.***> schrieb am Fr., 4. Aug. 2023, 05:01:

@rurban https://github.com/rurban Got it. I've noticed that with the current quick iteration, maybe we can create our own registry for quick iterative updates, and then push it to the official VCPKG registry when it stabilizes. Please refer to:

• create registry https://learn.microsoft.com/en-us/vcpkg/maintainers/registries, and refer to the example https://github.com/northwindtraders/vcpkg-registry.
• using registry https://learn.microsoft.com/en-us/vcpkg/users/registries, and refer to example https://github.com/northwindtraders/beison-ptr.

I'm rather happy with you pushing to the registry for releases. Nightlies not so much.

Reini