bagit-java
bagit-java copied to clipboard
Adapt parsing Bagit Profile due to specification.
Adapt parsing Bagit Profile due to specification. (https://github.com/bagit-profiles/bagit-profiles)
Inclusion of "Contact-Name," "Contact-Phone" and "Contact-Email," as defined in the BagIt spec, is not required but is encouraged. -> Add "Contact-Phone" -> "Contact-Name" and "Contact-Email" are now optional Add test for minimal profile Adapt other tests. Bag-Info: The parameters "required" is 'false' and "repeatable" is 'true' by default. Changed implementation accordingly. ("repeatable": Not used yet inside the library!?)
Please ensure you have completed the following before submitting:
- [x] Ran all tests to ensure existing functionality wasn't broken
- [x] Ran all quality assurance checks and fixed any new errors or warnings, which include:
Note: you can complete both boxes by running and fixing warnings/errors with gradle clean check
- [x] Code is self documenting or a short comment when self documenting isn't possible
Coverage increased (+0.04%) to 98.319% when pulling e6ce9a79ec749004e0da6dc843fbfdbcc0a8c4db on VolkerHartmann:master into 2b7002e62d721f5eb50461e4c4c70a6ef643ec1d on LibraryOfCongress:master.
Awesome work! I had a couple questions but overall really great work
@jscancella: Have you seen my changes yet? It would be great if you'd take a look at them.
Looks good to me. Now you just need someone at LC to merge it
@acdha It'd be great if you could merge the code.
@VolkerHartmann I'm not a member of this particular repository
Who is currently maintaining bagit-java at @LibraryOfCongress?
#125 and #128 seem ready for merging but the discussion sort of fizzled out.
Is there some way to help out with testing/deployment etc.?
@dbrunton
@kba I suspect after I left the answer is no one.