bagit-java icon indicating copy to clipboard operation
bagit-java copied to clipboard

Adapt parsing Bagit Profile due to specification.

Open VolkerHartmann opened this issue 7 years ago • 8 comments

Adapt parsing Bagit Profile due to specification. (https://github.com/bagit-profiles/bagit-profiles)

Inclusion of "Contact-Name," "Contact-Phone" and "Contact-Email," as defined in the BagIt spec, is not required but is encouraged. -> Add "Contact-Phone" -> "Contact-Name" and "Contact-Email" are now optional Add test for minimal profile Adapt other tests. Bag-Info: The parameters "required" is 'false' and "repeatable" is 'true' by default. Changed implementation accordingly. ("repeatable": Not used yet inside the library!?)

Please ensure you have completed the following before submitting:

  • [x] Ran all tests to ensure existing functionality wasn't broken
  • [x] Ran all quality assurance checks and fixed any new errors or warnings, which include:

Note: you can complete both boxes by running and fixing warnings/errors with gradle clean check

  • [x] Code is self documenting or a short comment when self documenting isn't possible

VolkerHartmann avatar Nov 12 '18 09:11 VolkerHartmann

Coverage Status

Coverage increased (+0.04%) to 98.319% when pulling e6ce9a79ec749004e0da6dc843fbfdbcc0a8c4db on VolkerHartmann:master into 2b7002e62d721f5eb50461e4c4c70a6ef643ec1d on LibraryOfCongress:master.

coveralls avatar Nov 12 '18 09:11 coveralls

Awesome work! I had a couple questions but overall really great work

jscancella avatar Nov 13 '18 12:11 jscancella

@jscancella: Have you seen my changes yet? It would be great if you'd take a look at them.

VolkerHartmann avatar Nov 27 '18 10:11 VolkerHartmann

Looks good to me. Now you just need someone at LC to merge it

jscancella avatar Nov 27 '18 12:11 jscancella

@acdha It'd be great if you could merge the code.

VolkerHartmann avatar Nov 27 '18 14:11 VolkerHartmann

@VolkerHartmann I'm not a member of this particular repository

acdha avatar Nov 27 '18 14:11 acdha

Who is currently maintaining bagit-java at @LibraryOfCongress?

#125 and #128 seem ready for merging but the discussion sort of fizzled out.

Is there some way to help out with testing/deployment etc.?

@dbrunton

kba avatar Nov 27 '18 14:11 kba

@kba I suspect after I left the answer is no one.

jscancella avatar Nov 27 '18 14:11 jscancella