library-python icon indicating copy to clipboard operation
library-python copied to clipboard

lesson 00 - intro - comments

Open richyvk opened this issue 9 years ago • 1 comments

Have done a bit of a review of the first lesson. Some thoughts:

  • line 27 - Supports multiple programming paradigms - what does this mean?
  • line 32 - Python is an interpreted language - I think this might need to be explained a bit more too
  • line 82 - The variable called text is a string which means it can contain letters and numbers - add 'as text characters?' or something like that.
  • line 122+ operators section - do we need examples for each? Only have some currently. Particularly the comparisons, like != etc
  • line 184 - Each element can be accessed by an index: - Add 'starting at 0 for the first element' or similar.
  • line 211 - indentation - should we say the accepted standard is to indent by 4 spaces?
  • line 245 - Change "We can also access a list of methods using dir" to "We can also access a list of methods available to an object using dir"
  • line 291 - What is the object type? - I wonder if this section could be moved up, or maybe good to have a small section on objects generally - not specific to tuples.
  • line 316 - Keys can only have particular types - they have to be "hashable" - wondering if there's a simpler way of defining keys for a beginner (e.g. "Strings or numbers are the most common") - or explain what hashable means.
  • Dictionary section exmples - I'm wondering if rev is the best example to use - simply because the keys are integers, this might confuse people into thinking they're using positions to retreive values, like with lists. I think the translation dict used first is a better option for all examples.
  • line 425 - A function allows you to group code together for reuse and readability. - Do we need readability - a function can still be hard to read, right?

richyvk avatar Nov 17 '16 06:11 richyvk

I'm working on above issues and other similar changes for mozsprint. Will submit pull requests section by section.

histlib avatar Jun 02 '17 14:06 histlib