lc-shell icon indicating copy to clipboard operation
lc-shell copied to clipboard

Remove hidden directory from data

Open ndporter opened this issue 1 year ago • 7 comments

The shell-lesson-data.zip file includes a hidden __MACOSX directory that is visible when running ls in Git Bash (and thus potentially confusing to learners. Ideally, the datafile should be updated to remove this extra cognitive load (and filesize) unless there is a reason it needs to be there.

ndporter avatar Aug 08 '23 13:08 ndporter

I think that the removing the __MACOSX folder would impact the MacOS users and require separate lesson files. That's my guess, I'm a Windows/Linux user so anything specific to MacOS is a guess for me.

That said I don't think a brief explanation would throw the class off course. It might be helpful for new users to know what to ignore based on their OS.

contents directory

jmjamison avatar Sep 29 '23 19:09 jmjamison

I think the __MACOSX file is not necessary. But I can test if you want me to.

emcaulay avatar Sep 30 '23 01:09 emcaulay

@emcaulay If you could test this out that would be very helpful. Not using MacOS I have no idea if that file is necessary. Thank you.

jmjamison avatar Sep 30 '23 03:09 jmjamison

I tested it, and that part of the file is not necessary. I made a new zip and shared with @jmjamison -- and I think it's free of Mac detritus. Jamie will review next week.

emcaulay avatar Sep 30 '23 03:09 emcaulay

(I shared a new zip with her via Slack since I can't upload the zip to the repo)

emcaulay avatar Sep 30 '23 03:09 emcaulay

And I learned something new about MacOS files.

jmjamison avatar Sep 30 '23 03:09 jmjamison

@jmjamison has this new file been update in this repo? I didn't notice any pull request for it.

kaitlinnewson avatar Oct 10 '23 16:10 kaitlinnewson