LibRaw LLC
LibRaw LLC
@silb thank you for the samples. LibRaw (library) is not affected by the issue (because of less strict rules used when selecting CR3 track)
Thanks! There are already omp critical in crx decoder, so adding additional lock will result into deadlock. Fix expected in a 10 minutes or so :)
This one should fix the problem: https://github.com/LibRaw/LibRaw/commit/90b8e6b5af9974b9b7f3bc6ac2a2611d06b753c5
Yes, FITS write is completely out of scope for LibRaw. The problem not in this specific addition to unprocessed_raw, but adding this manifests that 'fits is generally provided by libraw'...
My point is: 1. Metadata output is already added to LibRaw tiff writer (part of the library itself), it is controlled via params.output_flags, so should be improved. 2. unprocessed_raw is...
Thank you for your effort. Too much to accept as single merge, also some changes may break everything (for example: exception in mem manager may be unhandled if called outside...
We do not want to fix what is not broken. Memmgr idea is borrowed from Apache memory pools, it worked for years. Expected result/effort ratio on replacing it with C++...
Exceptions in libraw methods are handled. Exceptions in constructor are not.
> I added [oss-fuzz](https://github.com/google/oss-fuzz/tree/master/projects/kimageformats) tests yesterday for a Qt plugin using libraw and we noticed several crashes. I have no idea if this patch fixes them all, but it feels...
Sure, we need to have malformed input file and imgdata.params values (or dcraw_emu command line) to reproduce