LibRaw-cmake icon indicating copy to clipboard operation
LibRaw-cmake copied to clipboard

Add support to enable LIBRAW_CALLOC_RAWSTORE

Open perdrix52 opened this issue 1 year ago • 3 comments

LibRaw 0.23.1 has added a new compilation definition LIBRAW_CALLOC_RAWSTORE.

Given that this is a compiler define that will do no harm on earlier release and is otherwise benefical it could be added unconditionally, Or if you wish controlled by an option in the CMakeLists.txt file.

What do you think? David

perdrix52 avatar Nov 22 '24 13:11 perdrix52

Feel free to add a new CMake option, no need to add a version check.

letmaik avatar Nov 23 '24 17:11 letmaik

I know enough CMake to use it, and am beginning to to write my own simple CMake files, but don't think I have the skills to do this yet.

perdrix52 avatar Nov 23 '24 18:11 perdrix52

Just use -DCMAKE_CXX_FLAGS=LIBRAW_CALLOC_RAWSTORE directly, a dedicated option is perhaps overkill and doesn't really reduce verbosity here (unless it is set to be ON by default).

kmilos avatar Sep 26 '25 10:09 kmilos