LibRaw-cmake icon indicating copy to clipboard operation
LibRaw-cmake copied to clipboard

Fix incorrect pdb names

Open jedfrechette opened this issue 4 years ago • 3 comments

Closes #29

jedfrechette avatar Jan 26 '22 19:01 jedfrechette

Anything that prevents from merging this PR? I'm hitting the same issue! Thanks @jedfrechette for fixing it!

UPD. There's also this issue that ./Debug/ folder is missing in the path before the raw.pdb - should probably add ${CMAKE_BUILD_TYPE}/

ribtoks avatar Sep 02 '23 15:09 ribtoks

@ribtoks It would be helpful if you could test this locally and submit a new PR given that the original author isn't responsive.

letmaik avatar Sep 02 '23 17:09 letmaik

https://github.com/LibRaw/LibRaw-cmake/pull/40 Literally just "tested locally" on Windows 10 and ended up using my temporary fork as this change is not in the main repository. Seems to work "on my computer" just fine. Visual Studio 2019, CMake 3.18.4

ribtoks avatar Sep 02 '23 17:09 ribtoks