landmarks icon indicating copy to clipboard operation
landmarks copied to clipboard

Published 20 hours ago • verified publisher icon LexiFi

Viewer ?

Open dbuenzli opened this issue 6 years ago • 8 comments

Hello,

The online viewer is a 404 and the package landmarks-viewer mentioned in the README doesn't exist.

dbuenzli avatar Jan 12 '19 22:01 dbuenzli

is there a way to use landmarks in json mode currently at all?

nilsbecker avatar Apr 10 '19 10:04 nilsbecker

I'm trying to use landmarks and just hit this issue. Are there any updates?

Armael avatar Jan 19 '20 18:01 Armael

FYI: I've just hacked a mode to write the "textual format" in a way that is readable by emacs' org-mode (in particular, this supports folding/unfolding items of the tree), which makes for a very usable viewer.

The code is here, I'll make a PR at some point: https://github.com/Armael/landmarks/tree/format-org

lm-org

Armael avatar Jan 19 '20 22:01 Armael

Hello everyone,

I revived the landmarks-viewer !

You should be able to test it online. Just run your executable with OCAML_LANDMARKS=format=json,output=profile.json and load the file in the online viewer.

If you want to have it locally, you can clone the repository. The instructions in the README.md should be enough to build the two files ("landmark_viewer.html" and "landmark_viewer.js").

Note that you'll need the master branch version of gen_js_api (it has not yet been released to opam). And I'll try to release the viewer on opam as soon as gen_js_api is released !

mlasson avatar Jan 20 '20 10:01 mlasson

I'll close the issue when it will be available on opam.

mlasson avatar Jan 20 '20 11:01 mlasson

What is the current status of:

  • the landmarks viewer as an opam package?
  • @Armael's org-mode output?

gasche avatar Mar 25 '21 12:03 gasche

I haven't touched the org-mode output since last time, but IIRC it was basically working and the patch was clean. It's still sitting in the branch linked above.

Since the online viewer wasn't working for me (haven't investigated why), I've used my org-mode output a couple times since then.

So I think it's mostly a matter of rebasing it and making the PR. I don't have time right now, but I'm happy to give you access to my fork if you have some cycles available.

Armael avatar Mar 25 '21 12:03 Armael

Thanks! I don't need write commit to your fork (I can fetch your fork and resubmit a PR if need be, which sounds cleaner); it just landed in the middle section of my TODO list.

gasche avatar Mar 25 '21 12:03 gasche