Lewis A. Jones
Lewis A. Jones
Hmmmm that would work, but then this is ultimately not that different to having a `rank` argument. I guess in theory, we should also have `tax_certainty_family`, etc which could end...
I've been working on this a little bit this morning. My idea is to update this function, retaining the `rank` field which will be used to control which values are...
Hi @mcnikolic, do you think you'll have chance to implement these changes soon? Should we aim to get this function into the next version?
Hi @mcnikolic, is this function ready for review again? I see that it is currently failing the standard R CMD checks
Hi @harrietdrage, as discussed at CPEG, this is probably a good first function to develop to gain a bit of experience. If you are still interested, we'll reserve this issue...
A couple of additional features we could also consider for this function if we wanted to broaden scope: - Convert from tibble to dataframe - Generic error checking This function...
This is definitely something to discuss if we get the RSMF....
Thanks for sharing @RussellGarwood! That's super helpful to have to get us started.
That's a nice find, but is it completely applicable here? The `data.frame` we return is not some appended version of the original input `data.frame`. Unless the user has row names...
Hi @jf15558 @willgearty, I would definitely like to review this before it ends up in the package! I'm a little busy the next week or two with getting things ready...