Timofey Kazantsev

Medium-level API: Add PPQ functions

5

midi_get_ppq_pos_start_of_measure midi_get_ppq_pos_end_of_measure midi_get_proj_qn_from_ppq_pos midi_get_ppq_pos_from_proj_qn midi_get_proj_time_from_ppq_pos midi_get_ppq_pos_from_proj_time every PPQ function is unsafe, because of take requirement

Midi functions draft

3

I've just built an iterator, that returns arbitrary "generic" midi events with PPQ position and all flags unpacked. Then the decision is needed what to do: - stop on this...

alphabet medium-level covering

4

I'll move alphabetically through functions which can be straightforwardly wrapped. So, basically, this PR can be merged in master time to time without big concerns.

`Main_SaveProjectEx` is not loaded.

2

I'm not sure, where the issue corresponds to: `reaper-low`, CPP API or somewhere else. I definitely used this function from Python 2-3 years ago. And I think, it exists with...

Re-export and document `BitFlags` usage.

1

I found in tests.rs, that I cannot simply use `BitFlags` struct. I think, that I should include them as dependency in `Cargo.toml`, than try to construct in the test function....

`set_ext_state` `get_ext_state` `has_ext_state` `delete_ext_state` `set_project_ext_state` `set_project_ext_state_unchecked` `get_project_ext_state` `get_project_ext_state_unchecked` `delete_project_ext_state` — verbose function to pass empty string. `delete_project_ext_state_unchecked` `enum_project_ext_state` with `EnumProjectExtStateResult` `enum_project_ext_state_unchecked` As `enum_project_ext_state` expects two string buffers, also introduced: `create_string_buffer`...

Ambiguos medium-level API

3

Here are functions I'm not sure in. Which are better to discuss.

Can not make integration test fail.

4

I'm working on MIDI functions, and can not make integration test fail by `assert!` macros. If I'm directly using `panic!` it fails, but with literally wrong `assert_eq!("one string", "another string");`...

Non-latin characters are displayed as '?'

1

`Linux 5.11.0-49-lowlatency #55-Ubuntu SMP PREEMPT Wed Jan 12 18:18:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux` `Reaper 6.44, sws-2.12.1.3-Linux-x86_64`  I see some troubles of unicode rendering. At the first glance...

there was error in reaper_python that raised exception on empty strings. Also, `GetTrackMidiNoteName` uses track index, not id