ember-statecharts
ember-statecharts copied to clipboard
switch from ember-usable to ember-could-get-used-to-this
implementation: https://github.com/pzuraq/ember-could-get-used-to-this/pull/10/files
NOTE: this'll be a breaking change for ember-statecharts and, at the time of writing, requires ember-source@beta
The entire spike by @pzuraq seems pretty much work in progress. Is this tied to beta features of Ember 3.22+? Does it make sense to mark this PR as a draft if this is the case?
Yes. Also, hopefully there will be a polyfill for @ember/helper
and friends used by the new usable wip work
ok marked as a draft @NullVoxPopuli - thanks for the heads up on the change :+1:
unconfirmed, but it seems I'm maybe stuck on Ember 3.21.x until this is out? ember-usable seems to be showing some age. 🤔
I'll try to get this finished up this week
@NullVoxPopuli would be surprising if you were stuck. ember-usable
was working before the helper-manager stuff that the new version depends on?! Could you confirm this?
If this was an actual issue with ember-usable I think the solution would be more complicated because versions > 3.22 would need to work differently. Unless the helper changes are polyfillable?
Here are the errors I get with latest ember: https://github.com/NullVoxPopuli/emberclear/pull/1284/checks?check_run_id=1527736502
I assumed it was related to the polyfill because all the failing tests have a statechart involved
For reviewing purposes, most of the irrelevant changes are in the first commit - dependency and lockfile changes