ember-statecharts icon indicating copy to clipboard operation
ember-statecharts copied to clipboard

switch from ember-usable to ember-could-get-used-to-this

Open NullVoxPopuli opened this issue 4 years ago • 7 comments

implementation: https://github.com/pzuraq/ember-could-get-used-to-this/pull/10/files

NOTE: this'll be a breaking change for ember-statecharts and, at the time of writing, requires ember-source@beta

NullVoxPopuli avatar Oct 25 '20 12:10 NullVoxPopuli

The entire spike by @pzuraq seems pretty much work in progress. Is this tied to beta features of Ember 3.22+? Does it make sense to mark this PR as a draft if this is the case?

LevelbossMike avatar Oct 26 '20 10:10 LevelbossMike

Yes. Also, hopefully there will be a polyfill for @ember/helper and friends used by the new usable wip work

NullVoxPopuli avatar Oct 26 '20 11:10 NullVoxPopuli

ok marked as a draft @NullVoxPopuli - thanks for the heads up on the change :+1:

LevelbossMike avatar Oct 26 '20 15:10 LevelbossMike

unconfirmed, but it seems I'm maybe stuck on Ember 3.21.x until this is out? ember-usable seems to be showing some age. 🤔

I'll try to get this finished up this week

NullVoxPopuli avatar Dec 08 '20 14:12 NullVoxPopuli

@NullVoxPopuli would be surprising if you were stuck. ember-usable was working before the helper-manager stuff that the new version depends on?! Could you confirm this?

If this was an actual issue with ember-usable I think the solution would be more complicated because versions > 3.22 would need to work differently. Unless the helper changes are polyfillable?

LevelbossMike avatar Dec 10 '20 12:12 LevelbossMike

Here are the errors I get with latest ember: https://github.com/NullVoxPopuli/emberclear/pull/1284/checks?check_run_id=1527736502

I assumed it was related to the polyfill because all the failing tests have a statechart involved

NullVoxPopuli avatar Dec 10 '20 12:12 NullVoxPopuli

For reviewing purposes, most of the irrelevant changes are in the first commit - dependency and lockfile changes

NullVoxPopuli avatar Dec 18 '20 19:12 NullVoxPopuli