Erik van der Bas comments

Results 143 comments of


                                            Erik van der Bas

Change destination folder for Resize.

Closing as stale

Add possibility to disable cropping in resize function #1332

Hi @idflood , thank you for your ticket back then. Since we are not going to actively put new features in Timber 1, I am going to close your PR....

Timber\MenuItem->master_object returns wrong object for WooCommerce product categories

This should be fixed nowaydays in [Timber 2.0](https://github.com/timber/timber/blob/e6a8957afeed29aebf8fecc3fb2fecddbd8ea89c/src/MenuItem.php#L280)

Timber resize path incorrect when using roots/soil relative urls

Third party related. Going to close since there are multiple workaround noted.

JPGs generated from PNGs by img_to_jpg function aren't deleted when original PNG is deleted

Tested this issue and #2556 fixes it. Added has patch tag.

Any roadmap for 2.* release?

Hi everyone, the team is hard at work to make Timber 2.0 happen. We've just created an updated roadmap with open tickets, pull requests, etc. If you would like to...

Timber::get_image returns false when ACF image passed in.

Closing as stale

Discrepancies between using new Timber\Post(); Timber::query_post(); and Timber::get_post(); using LearnDash Plugin

Hi @MarcAtNuRelm I hope the excellent explanation of @aj-adl cleared things up. I am going to close this as stale for now.

ACF meta field accessed via Term model aren't processed by ACF integration

Closing this as this issue seems resolved in 2.0 branch as stated.

Empty img element when there is no featured image

I think A small check to add to a single page is not really that hard to do and gives a good example. I will mark this as an enhancement.