designSpaceRoboFontExtension icon indicating copy to clipboard operation
designSpaceRoboFontExtension copied to clipboard

save designspace with unsaved open UFO

Open typemytype opened this issue 1 year ago • 2 comments

popup a warning to save the unsaved UFO first

Traceback (most recent call last):
  File "/Users/frederik/Documents/dev/typesupply/vanilla/Lib/vanilla/dialogs.py", line 181, in completionHandler_
    self._resultCallback(self._result)
  File "/Users/frederik/Library/Application Support/RoboFont/plugins/DesignspaceEditor2.roboFontExt/lib/designspaceEditor/ui.py", line 1969, in saveDesignspace
    sourceDescriptor.filename = os.path.relpath(sourceDescriptor.path, root)
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen posixpath>", line 509, in relpath
ValueError: no path specified
Traceback (most recent call last):
  File "/Users/frederik/Documents/dev/typesupply/vanilla/Lib/vanilla/dialogs.py", line 181, in completionHandler_
    self._resultCallback(self._result)
  File "/Users/frederik/Library/Application Support/RoboFont/plugins/DesignspaceEditor2.roboFontExt/lib/designspaceEditor/ui.py", line 1969, in saveDesignspace
    sourceDescriptor.filename = os.path.relpath(sourceDescriptor.path, root)
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen posixpath>", line 509, in relpath
ValueError: no path specified

typemytype avatar Oct 23 '24 12:10 typemytype

or save those unsaved UFO next to the designspace path? @LettError

typemytype avatar Nov 14 '24 22:11 typemytype

Maybe DSE should show a dialog "Save the sources first"

LettError avatar Nov 14 '24 22:11 LettError