give-me-coinsMonitoringApp icon indicating copy to clipboard operation
give-me-coinsMonitoringApp copied to clipboard

Unchecking "Show in Notification Bar" does not remove notification

Open justinmuller opened this issue 11 years ago • 3 comments

Extracted from issue #17

"@greg84: Also when I tick and untick the "show in notification bar" checkbox I have to exit and restart the app before the notification appears or is removed."

justinmuller avatar Dec 07 '13 19:12 justinmuller

This is confirmed and still a bug today. Idea: Should we maybe anchor the check of this in save settings onClick listener (service restart), just to make sure it is really up-to-date? I do not think people are clicking save settings that much, that it could cause a problem.

Letme avatar Jan 04 '14 00:01 Letme

What about doing away with the "Save Settings" and "Delete Settings" buttons?

  • The settings would be saved when the API key is obtained, a currency is toggled, or the update interval is changed. This of course would require some work so that the new settings are reflected in the running service.
  • Is the "Delete Settings" button used, and if so what is it used for? Is it being used for pseudo-multi account support? I think anyone that would want to delete the settings is probably going to uninstall anyway.

justinmuller avatar Jan 04 '14 00:01 justinmuller

If I remember right there was a request for Delete button somewhere as people added the wrong api key and had problem re-adding it. Might be legacy and not needed anymore. I like the idea of automatically saved settings but it might just not be worth the effort.

On Sat, Jan 4, 2014 at 1:16 AM, Justin Muller [email protected]:

What about doing away with the "Save Settings" and "Delete Settings" buttons?

  • The settings would be saved when the API key is obtained, a currency is toggled, or the update interval is changed. This of course would require some work so that the new settings are reflected in the running service.
  • Is the "Delete Settings" button used, and if so what is it used for? Is it being used for pseudo-multi account support? I think anyone that would want to delete the settings is probably going to uninstall anyway.

— Reply to this email directly or view it on GitHubhttps://github.com/Letme/give-me-coinsMonitoringApp/issues/21#issuecomment-31565001 .

Letme avatar Jan 04 '14 00:01 Letme