fast-formula-parser icon indicating copy to clipboard operation
fast-formula-parser copied to clipboard

fix(ranges): allow dollar signs

Open rkretzschmar opened this issue 2 years ago • 1 comments

This PR adds support for ranges like $A1:$A3 or $1:$3 I found in an Excel file lately.

I added according unit tests.

Thanks for considering.

rkretzschmar avatar Aug 03 '22 14:08 rkretzschmar

IMO, Its better to add a new pattern

const RowAbsolute = createToken({
  name: 'RowAbsolute',
  pattern: /[$][0-9]/,
})

And add an ALT branching to referenceItem rule

{
  ALT: () => {
    const address = $.CONSUME(RowAbsolute).image;
    return $.ACTION(() => {
      const row = this.utils.extractRowFromAddress(address)
      return $.ACTION(() => this.utils.parseRow(row));
    });
  },
}

rmdort avatar May 29 '23 16:05 rmdort