Florian Bach

Results 150 comments of Florian Bach

Is there any update yet @andrewshadura ? Do you plan to review and merge this eventually, or would I be better off maintaining my own fork of tnat64?

Looks like one of your tests is already failing in this branch. Question is, is my code broken or is your test broken? :)

Looks like the test is broken. With my changes it just no longer hits that code path. What was that test (`01-correct-ipv6-address`) supposed to test? A test for the invalid...

Ah, so basically just revert the existing test? Fail if it finds that string, success otherwise?

When executing this test, the current `main` version prints this: ``` 16:48:39 libtnat64(1610858): Opening configuration file (/etc/tnat64.conf) 16:48:39 libtnat64(1610858): New network entry for 10.0.0.0 16:48:39 libtnat64(1610858): New network entry for...

I just added a third test that verifies that netlink sockets can call getsockname without errors. This test fails on `main` but succeeds with this PR. I hope a dependency...

Any update yet? Is there something I still need to do, or do you just need to review this? Or do you want to switch to the new meson build...

Okay, I think this PR should now be somewhat ready for review as well if you want to take a look. Once my other PR (#8) is merged I'm going...

The python test was in the other PR (netlink), but yeah, that's what I thought. Python is not that uncommon, and I don't think writing a netlink test in Bash...