node-xml2js icon indicating copy to clipboard operation
node-xml2js copied to clipboard

Published 20 hours ago • verified publisher icon Leonidas-from-XIV

Migrate to xmlbuilder2?

Open Richienb opened this issue 4 years ago • 5 comments

The creator of the original xmlbuilder package, @oozcitak has reworked it to create xmlbuilder2. Should we migrate to it?

Useful resources

// @Leonidas-from-XIV

Richienb avatar Jun 29 '20 08:06 Richienb

What would be the advantages for xml2js?

Leonidas-from-XIV avatar Jul 08 '20 21:07 Leonidas-from-XIV

@Leonidas-from-XIV https://oozcitak.github.io/xmlbuilder2/upgrading-from-xmlbuilder.html#comparison-with-xmlbuilder

Richienb avatar Jul 09 '20 01:07 Richienb

I looked at this and couldn't find any tangible improvements, hence my question.

Leonidas-from-XIV avatar Jul 09 '20 06:07 Leonidas-from-XIV

Major improvement: get rid of circular dependency ! (XMLNode.js -> XMLxxxx.js -> XMLNode.js => rollup fail)

boulaya66 avatar Nov 21 '20 12:11 boulaya66

It turned out to be simplest to just migrate a whole library I never touched before from xml2js to xmlbuilder2 to get rollup to work. So, in a way, there truly aren't any advantages for xml2js.

szakharchenko avatar Aug 05 '21 08:08 szakharchenko