npm2deb icon indicating copy to clipboard operation
npm2deb copied to clipboard

send itp mail via npm2deb

Open nileshpatra opened this issue 6 years ago • 6 comments

Solves #45

nileshpatra avatar Oct 15 '19 19:10 nileshpatra

@guimard , did the changes as desired, using mail + editor.(seems to work on my machine) Could you please review?

nileshpatra avatar Oct 16 '19 07:10 nileshpatra

@guimard , did the changes as desired, using mail + editor.(seems to work on my machine) Could you please review?

Seems good for me. However, I've no talents in Python. I let review for someone else

guimard avatar Oct 16 '19 20:10 guimard

@guimard , did the changes as desired, using mail + editor.(seems to work on my machine) Could you please review?

Seems good for me. However, I've no talents in Python. I let review for someone else

Noted, Thanks a lot for guiding me, :)

@shanavas786 @LeoIannacone could you please review the PR?

nileshpatra avatar Oct 17 '19 09:10 nileshpatra

@nileshpatra Thanks for your contribution

did the changes as desired, using mail + editor.(seems to work on my machine)

Does it invoke editor in your system ?

shanavas786 avatar Oct 22 '19 08:10 shanavas786

@nileshpatra Thanks for your contribution

did the changes as desired, using mail + editor.(seems to work on my machine)

Does it invoke editor in your system ?

No, you would need to modify the template (_itp.mail) on doing npm2deb senditpmail package-name_itp.mail, it should send the mail.

nileshpatra avatar Oct 22 '19 09:10 nileshpatra

well, then the subject should not contain 'FIX_ME', would be better to capture it from user. You may also warn/abort if the ITP file contains any 'FIX_ME' s

shanavas786 avatar Oct 29 '19 04:10 shanavas786