Petals icon indicating copy to clipboard operation
Petals copied to clipboard

Published 20 hours ago • verified publisher icon LeoColman

Added InAppPurchase

Open rahim001-sudo opened this issue 1 year ago • 7 comments

rahim001-sudo avatar Sep 07 '24 14:09 rahim001-sudo

@rahim001-sudo If you take a look, each individual check have details on why they failed

LeoColman avatar Sep 07 '24 17:09 LeoColman

@LeoColman Yes 3 of them failed. Also Build Universal Apk (Fdroid apk) says unresolved reference for the code i have done. i think i will study the project structure more now for the next PR. also in Studio it was working. I had used playstoreDebug as primary so i thought we are good to go 😄 .

rahim001-sudo avatar Sep 07 '24 18:09 rahim001-sudo

@LeoColman i have made the fix . i think now the checks should pass.

rahim001-sudo avatar Sep 07 '24 19:09 rahim001-sudo

Yes i will make those changes. Please just now i was trying to test workflow so i had done a commit. i think that is asking for workflow review here. So please dont consider this as done. i am making changes as of now.

rahim001-sudo avatar Sep 08 '24 06:09 rahim001-sudo

I can see some commits have happened as of now its 19 so i think we will squash it . but before that is the PR Good or any changes are required.

rahim001-sudo avatar Sep 16 '24 17:09 rahim001-sudo

Yes, so far the PR is amazing, and your communication has been great!

I'm running some tests on my end now to see if changes are needed

LeoColman avatar Sep 17 '24 02:09 LeoColman

Thanks @LeoColman . Yes please let me know when done.

on a side note I am learning from this Repo actually as of now (Jetpack components,Koin, Github CI/CD and stuff and commands).

rahim001-sudo avatar Sep 17 '24 16:09 rahim001-sudo

I think we are good to go!

I tested with real Playstore items on two different phones and it seems to work well Thanks for the contribution @rahim001-sudo !!

LeoColman avatar Sep 18 '24 20:09 LeoColman

Yes Thanks for guiding me. Looking forward to make more contributions :smiley:

rahim001-sudo avatar Sep 19 '24 14:09 rahim001-sudo

As a token of symbolic gratitude, please take these promo codes for ad-free google play petals :) promotion_codes.csv

I imagine of course as you reached the repository that you would probably use the ad-free versions anyway :D

LeoColman avatar Sep 19 '24 15:09 LeoColman

@LeoColman Thank you so much for the promo codes. Means a lot. I would have used them. but I dont consume weed/any substance as of now😅.

(alcohol ban 👀) :D.

Sorry i had not opened notifications tab so missed it.

rahim001-sudo avatar Sep 21 '24 11:09 rahim001-sudo