Petals icon indicating copy to clipboard operation
Petals copied to clipboard

Add option to purchase ad free option

Open LeoColman opened this issue 2 years ago • 11 comments

LeoColman avatar Jan 02 '23 05:01 LeoColman

Product ID petals_remove_ads

LeoColman avatar Jun 05 '24 23:06 LeoColman

Hello Leo. I am interested in working on this feature. Can i work on this. ?.

rahim001-sudo avatar Sep 04 '24 18:09 rahim001-sudo

Hello Rahim!

Yes! Thanks for your interest! If you have any questions let me know

LeoColman avatar Sep 04 '24 18:09 LeoColman

Thanks Leo :) . I will definitely let you know if i will have any.

rahim001-sudo avatar Sep 04 '24 19:09 rahim001-sudo

Hi Leo. I have done the code for inAppPurchase but the products are not returned even for testId (android.test.purchased). I think we will have to add a account in license testing. from coding part i thinks its good.

rahim001-sudo avatar Sep 06 '24 15:09 rahim001-sudo

I see. Thanks Rahim!

Would you like to share an e-mail address to put as a license tester or would rather open the PR and leave this part to me?

LeoColman avatar Sep 06 '24 20:09 LeoColman

I have opened a PR. Actually I am new to open source and github commands So. . Please let me know if thats good enough or i will make the PR Again if there are any changes needed.

rahim001-sudo avatar Sep 07 '24 14:09 rahim001-sudo

No problem at all! Welcome to open source 😁

Next step is to ensure repository checks are passing and then I'll review the code.

You'll be able to see the comments on the pr itself when I make them, and add new commits to fix them.

Once we are done we'll squash all the commits in one and merge it to the main branch

LeoColman avatar Sep 07 '24 14:09 LeoColman

Yaa i had seen it was pending before. The repository checks happens by themselves right after the PR is opened?.

i am googling it but is it possible to know if all the checks will pass or not locally in the system itself ?. i will look into these build issues and will update again.

rahim001-sudo avatar Sep 07 '24 18:09 rahim001-sudo

i am googling it but is it possible to know if all the checks will pass or not locally in the system itself

Yes, you need to check the commands that are executed in each workflow in the .github directory. The mains ones are the linter (Detekt) and build workflows

LeoColman avatar Sep 07 '24 19:09 LeoColman

Yes i had checked them out. i found out you can use ACT(https://github.com/nektos/act) for that running actions locally.

rahim001-sudo avatar Sep 09 '24 03:09 rahim001-sudo