angular2-sample-app icon indicating copy to clipboard operation
angular2-sample-app copied to clipboard

Update angular 2 references from RC7 to release (no breaking changes just update)

Open brauliodiez opened this issue 7 years ago • 10 comments

@apereap do you want to jump on this (just update package.json and check that apps keeps on running fine :)).

brauliodiez avatar Sep 28 '16 12:09 brauliodiez

If I update dependencies like this (I'm not sure if it's ok ...) "@angular/common": "^2.0.0", "@angular/compiler": "^2.0.0", "@angular/core": "^2.0.0", "@angular/forms": "^2.0.0", "@angular/platform-browser": "^2.0.0", "@angular/platform-browser-dynamic": "^2.0.0",

And execute npm install and then npm start, the apps run properly.

If I type dependencies like "2.0.0" (exactly) npm install doesn´t work, there are errors in dependencies.

I'm confused ...

apereap avatar Sep 28 '16 22:09 apereap

If you go to "node_modules" folder and for example @angular/core

package.json

...
"version": "2.0.1"
}

Maybe there are issues with 2.0.0 But it not have sense, because is a patch version

nasdan avatar Sep 29 '16 11:09 nasdan

Checked, I have "jumped" and all the apps run porperly.

"dependencies": { "@angular/common": "^2.0.1", "@angular/compiler": "^2.0.1", "@angular/core": "^2.0.1", "@angular/forms": "^2.0.1", "@angular/platform-browser": "^2.0.1", "@angular/platform-browser-dynamic": "^2.0.1", "@angular/router": "^3.0.1", "bootstrap": "^3.3.7", "core-js": "^2.4.1", "file-loader": "^0.9.0", "jquery": "^3.1.1", "reflect-metadata": "^0.1.8", "rxjs": "^5.0.0-beta.12", "url-loader": "^0.5.7", "zone.js": "^0.6.25" }

apereap avatar Sep 29 '16 11:09 apereap

file-loader and url-loader must be in devDependencies

nasdan avatar Sep 29 '16 11:09 nasdan

Thank you @Nasdan ,

I have to learn a lot ...

Here is the new devDependencies and dependencies:

"devDependencies": { "css-loader": "^0.25.0", "extract-text-webpack-plugin": "^1.0.1", "file-loader": "^0.9.0", "html-webpack-plugin": "^2.22.0", "style-loader": "^0.13.1", "ts-loader": "^0.8.2", "typescript": "^1.8.10", "typings": "^1.3.3", "url-loader": "^0.5.7", "webpack": "^1.13.2", "webpack-dev-server": "^1.15.1" }, "dependencies": { "@angular/common": "^2.0.1", "@angular/compiler": "^2.0.1", "@angular/core": "^2.0.1", "@angular/forms": "^2.0.1", "@angular/platform-browser": "^2.0.1", "@angular/platform-browser-dynamic": "^2.0.1", "@angular/router": "^3.0.1", "bootstrap": "^3.3.7", "core-js": "^2.4.1", "jquery": "^3.1.1", "reflect-metadata": "^0.1.8", "rxjs": "^5.0.0-beta.12", "zone.js": "^0.6.25" }

apereap avatar Sep 29 '16 11:09 apereap

No problem :)

nasdan avatar Sep 29 '16 12:09 nasdan

Great give us a shout when you have a PR ready (you can as well associate your fork to this issue, just by indicating in a commit comment #18 )

brauliodiez avatar Oct 02 '16 11:10 brauliodiez

Ok, I'm using SourceTree but I can't do a PR.

This is the error: git -c diff.mnemonicprefix=false -c core.quotepath=false push -v --tags --set-upstream origin master:master remote: Permission to Lemoncode/angular2-sample-app.git denied to apereap.

fatal: unable to access 'https://github.com/Lemoncode/angular2-sample-app.git/': The requested URL returned error: 403 Pushing to https://github.com/Lemoncode/angular2-sample-app.git

Completed with errors, see above.

I'm doing something wrong and I have to solve it. But I'm not sure how. ¬¬U

apereap avatar Oct 02 '16 19:10 apereap

No prob, yo uhave to push to your forked repo, the repo you are hitting it he original one and you don't have push access ;-).

If you need help we can connecto mon or tue

brauliodiez avatar Oct 02 '16 19:10 brauliodiez

Done :)

apereap avatar Oct 02 '16 21:10 apereap