Prevent stack overflow when fetching nested comment

Open dullbananas opened this issue 7 months ago • 1 comments

Requires https://github.com/LemmyNet/activitypub-federation-rust/pull/145

Jun 15 '25 07:06 dullbananas

With this change can you increase the max comment depth and the nested comment api test to 100 without crashing?

Even with your comment its not clear how lazy helps, and shouldnt dereference be called inside the lazy closure?

Jun 16 '25 10:06 Nutomic

With this change can you increase the max comment depth and the nested comment api test to 100 without crashing?

It does work with 100. It also works with 500 (it takes 2 minutes though) with additional adjustments including DROP INDEX idx_path_gist.

Jul 20 '25 04:07 dullbananas

With this we could theoretically increase the max comment depth, though 50 seems more than enough.

Jul 22 '25 09:07 Nutomic