lemmy icon indicating copy to clipboard operation
lemmy copied to clipboard

Removing a few more Result<bool> .

Open dessalines opened this issue 1 year ago • 1 comments

Result<false> is confusing, when really we only want to a pass or fail check on a lot of these.

I've removed several of these a while back, but found a clean way to convert more of them.

dessalines avatar Aug 13 '24 20:08 dessalines

K this is ready to be looked at again. Some of the pass/fail checks needed to change their queries to select(not(exists from select(exists, to prevent a missing case from throwing an error.

IE a person block check should only throw an error if a row is found, not missing.

dessalines avatar Aug 14 '24 15:08 dessalines

Waiting for @dullbananas to have another look, after that we can merge.

Nutomic avatar Sep 19 '24 08:09 Nutomic

There would be failing tests if my logic above wasn't right. I'll merge after this passes and we can correct later if necessary.

dessalines avatar Sep 24 '24 00:09 dessalines