lemmy icon indicating copy to clipboard operation
lemmy copied to clipboard

Image proxy fixes

Open sunaurus opened this issue 1 year ago • 1 comments

This fixes two issues with image proxying:

  1. Ensure that the original image url gets written to remote_image, rather than the proxied url). Otherwise, the url validation logic in the image_proxy/ endpoint does not work.
  2. Remove an unnecessary URL decode step in the image_proxy logic. The URLs at this point are already decoded enough, any remaining encoded parts are actually part of the original URL, so decoding them again here will break such URLs (and make the validation fail).

sunaurus avatar Jun 27 '24 06:06 sunaurus

Same issue. Clicking on an image in chat does nothing. Restarting app not helping.

Caprine v2.60.1. From PopShop, flatpak version.

System info

OS: Pop!_OS 22.04 LTS x86_64 
Host: MS-7B17 2.0 
Kernel: 6.9.3-76060903-generic 
Uptime: 3 hours, 40 mins 
Packages: 2447 (dpkg), 47 (flatpak), 8 (snap) 
Shell: bash 5.1.16 
Resolution: 1920x1080, 3440x1440 
DE: GNOME 42.9 
WM: Mutter 
WM Theme: Pop-dark 
Theme: Pop-dark [GTK2/3] 
Icons: Pop [GTK2/3] 
Terminal: gnome-terminal 
CPU: Intel i7-8700K (12) @ 4.700GHz 
GPU: NVIDIA GeForce RTX 2080 Ti Rev. A 
GPU: Intel CoffeeLake-S GT2 [UHD Graphics 630] 
Memory: 16419MiB / 31959MiB 

tjaska avatar Jul 02 '24 11:07 tjaska

I believe this should be fixed in v2.60.3. If you're still having this issue with that version, feel free to reopen this issue.

mquevill avatar Dec 01 '24 19:12 mquevill