lemmy icon indicating copy to clipboard operation
lemmy copied to clipboard

Remove opentelemetry

Open Nutomic opened this issue 1 year ago • 4 comments

While upgrading dependencies in #4740 I also tried to upgrade the opentelemetry dependencies, but it was a huge hassle. As this stuff is behind a feature flag anyway and probably not used much, it seems better to get rid of it entirely. As a side effect, HTTP requests are now logged in a single line like this: 2024-05-23T14:32:56.677187Z INFO actix_web::middleware::logger: 127.0.0.1 'GET /api/v3/site HTTP/1.1' 200 10945 '-' 'curl/8.7.1' 0.015846

Nutomic avatar May 23 '24 14:05 Nutomic

fwiw the opentelemetry dependencies are tied to the tracing-opentelemetry dependency. tracing-opentelemetry does not yet have a release that supports the latest opentelemetry libs, so updating is not currently possible

asonix avatar May 23 '24 14:05 asonix

Probably worth asking some instance admins if they use otel with lemmy. If this is breaking it should still be removed, but still good to ask to see if they care about telemetry and would like a substitute for otel.

SleeplessOne1917 avatar May 23 '24 15:05 SleeplessOne1917

Nothing4You asked in the admin chat if anyone uses it and got no response at all. Anyway we can leave it for 0.20 as its technically a breaking change.

Nutomic avatar May 24 '24 08:05 Nutomic

Lets mark all these breaking changes PRs that we shouldn't merge yet into main, as drafts.

dessalines avatar May 24 '24 13:05 dessalines

Ready to merge

Nutomic avatar Sep 10 '24 10:09 Nutomic