lemmy icon indicating copy to clipboard operation
lemmy copied to clipboard

[Enhancment]: Add PaginationCursor for GetCommunitiesResponse (and possibly others)

Open SleeplessOne1917 opened this issue 11 months ago • 5 comments

Requirements

  • [X] Is this a bug report? For questions or discussions use https://lemmy.ml/c/lemmy_support
  • [X] Did you check to see if this issue already exists?
  • [X] Is this only a single bug? Do not put multiple bugs in one issue.
  • [X] Is this a backend issue? Use the lemmy-ui repo for UI / frontend issues.

Summary

The lack of pagination cursors for comments makes it impossible to fix this UI bug. It may be also useful to have pagination cursors for other list responses.

SleeplessOne1917 avatar Mar 08 '24 02:03 SleeplessOne1917

Turns out that this hasnt been implemented yet for comments.

Nutomic avatar Mar 08 '24 10:03 Nutomic

@Nutomic should cursor pagination be implemented for basically any response we return from the server that has a list of content (e.g. posts, comments, reports, messages, communities, users)? If this is the case, should there be a different type of PaginationCursor for each or only one (or multiple that impl a common trait)?

SleeplessOne1917 avatar Mar 08 '24 17:03 SleeplessOne1917

cc @dessalines @dullbananas

Nutomic avatar Mar 11 '24 09:03 Nutomic

should cursor pagination be implemented for basically any response we return from the server that has a list of content (e.g. posts, comments, reports, messages, communities, users)?

Yes

should there be a different type of PaginationCursor for each or only one (or multiple that impl a common trait)?

Multiple, and I don't think a trait is needed

dullbananas avatar Mar 11 '24 14:03 dullbananas

GetPersonDetails would also benefit from this.

Sjmarf avatar Jun 12 '24 18:06 Sjmarf