lemmy icon indicating copy to clipboard operation
lemmy copied to clipboard

Remove SendActivity and Perform traits, rely on channel

Open Nutomic opened this issue 2 years ago • 1 comments

These traits arent necessary anymore now that websocket is removed. Removing them allows us to use normal actix http handler methods which are much more flexible, and allow using different middlewares as well as setting response attributes.

Nutomic avatar Jul 12 '23 09:07 Nutomic

Yes this is still work in progress. I got it to compile now, and create activity is federating. Other activities are failing for some reason, and the code probably needs cleanup.

Its not necessary to convert other actions at the same time. Those can be done in separate PRs which will help to avoid conflicts.

Nutomic avatar Jul 12 '23 14:07 Nutomic

Finally got this working, although the code may not be the most elegant. Ready to merge.

Nutomic avatar Jul 19 '23 09:07 Nutomic