lemmy icon indicating copy to clipboard operation
lemmy copied to clipboard

Use specific Rust nightly version for CI cargo fmt (fixes #3467)

Open Nutomic opened this issue 2 years ago • 2 comments

Nutomic avatar Jul 10 '23 14:07 Nutomic

What was the reason for hard-coding the nightly version again?

dessalines avatar Jul 11 '23 13:07 dessalines

LGTM, just it might cause issues if people make PRs and you say they should run cargo +nightly fmt because that might then differ from what the CI does. Also fix-clippy.sh uses cargo +nightly fmt

Thats true but I dont want to keep updating the versions in so many places. If it causes problems then we can manually change the nightly version in CI.

What was the reason for hard-coding the nightly version again?

New nightly versions changing the formatting rules which made CI fail.

Nutomic avatar Jul 11 '23 13:07 Nutomic