lemmy
lemmy copied to clipboard
LemmyNet
Added primitive Spoiler Support by cloning nsfw functionality
Will implement #3185 once complete
Currently behaves in the exact same way as nsfw, which is not quite what is desired.
Many instances defederate nsfw on principle (nobidy willing to moderate nsfw) + tagging spoilers as nsfw limits the visibility in cases where all that was required is a content warning about spoilers such as chapter discussions/memes for ongoing series.
Edit: functionality wise this spoiler tag will only blur images/prevents text body preview + the ability to tag any post as a spoiler regardless of community while the regular nsfw tag will remain unchanged
I submitted this already as a draft so I can check woodpecker status while I add changes
Added the db migration manually but I have no idea if that is the correct way to go about it. If anybody stumbling in here knows how to do it please do enlighten me.
(I'm probably just too dumb to find it in the docs)
Added the db migration manually but I have no idea if that is the correct way to go about it. If anybody stumbling in here knows how to do it please do enlighten me.
(I'm probably just too dumb to find it in the docs)
kartikynwa told me how to
Images aren't blurred without use of NSFW + using NSFW means many instances block you and fewer users can see the content. That and in some communities (especially ones about ongoing stories) autolabeling every post as a Spoiler takes a lot of work off the back of users and mods.
Not being able to Tag Posts as Spoilers (similar to how it works on reddit) to blur Images and Hide text has been a real headache for the community I'm running an Instance for and I imagine other Novel/Story communities aren't fairing any better.
Edit: To elaborate, the issue is less the Spoilers being visible inside the community but rather everyone outside of it getting blasted with Spoilers. We have Anime and Manga readers on the Instance that would get showered in Spoilers when Browsing Local or All if we hadn't started using a rather cumbersome workaround to this and uploading blurred versions of memes with the unblurred image linked in the post body.
Edit 2: After double checking the Text Preview is also an issue, 0.18 UI does not honor immediate Spoiler tags either so not even using the provided tools works
Regarding Spoiler Tags in the Preview see the following images for the problem at hand:
The Post in the feed:
The same post opened up completely:
Images aren't blurred without use of NSFW + using NSFW means many instances block you and fewer users can see the content. That and in some communities (especially ones about ongoing stories) autolabeling every post as a Spoiler takes a lot of work off the back of users and mods.
Why would you not hide a spoiler image behind a spoiler tag? #317 is the issue to tag things with any potential tag.
Not being able to Tag Posts as Spoilers (similar to how it works on reddit) to blur Images and Hide text has been a real headache for the community I'm running an Instance for and I imagine other Novel/Story communities aren't fairing any better.
So its all about image previews? Why not hide them behind the spoiler tag? Otherwise people will see spoilers they don't want to see.
After double checking the Text Preview is also an issue, 0.18 UI does not honor immediate Spoiler tags either so not even using the provided tools works.
Those need to be fixed at the UI level then.
I'm not a fan of adding spoiler as a back-end specific concept, which we have to deal with all the complexities of federation and such, rather than as a markdown add-on that can be used in every community.
Why would you not hide a spoiler image behind a spoiler tag? https://github.com/LemmyNet/lemmy/issues/317 is the issue to tag things with any potential tag.
I'm not entirely sure what the plan for general tagging is so I approached the issue from a known standpoint where general Post tags are separate from nsfw and spoiler tags (2 very frequently used tags).
So its all about image previews? Why not hide them behind the spoiler tag? Otherwise people will see spoilers they don't want to see.
It's about Previews in general, Text Previews are only affected due to the non-functional Markdown in Previews though.
Those need to be fixed at the UI level then.
Looked at the issue as well and there's an entire discussion about not rendering markdown in previews there, simply hiding the entire post instead of making that work seemed simpler to me.
I'm not a fan of adding spoiler as a back-end specific concept, which we have to deal with all the complexities of federation and such, rather than as a markdown add-on that can be used in every community.
I disagree here, using a markdown add-on is way more of a hassle than it's worth here. Using a backend flag for spoilers it can be ensured that any non-lemmy instance will at least get the affected posts marked as "sensitive", effectively hiding the spoilers. The way it does that might not be ideal but it's better than nothing. Using markdown add-on's however will just not work there at all. Other applications federating with lemmy will just get blanket exposed to spoilers coming from lemmy unless they implement the same markdown plugins as lemmy does.
Other applications will also not support whatever custom attribute that would be used to federate this spoiler status. The only "spoiler" tag which is supported by existing Activitypub platforms is the sensitive flag, which is exactly what we use for nsfw posts. So these spoilers would also have to be tagged as sensitive, which means there would be no way to tell the difference between nsfw and spoiler when federating between Lemmy instances.
Its like dessalines said, this is not the right solution for the problem you are describing.
Appreciate your feedback, your response made it much clearer why this won't work, I hadn't realized the issues. I found some resources that might help implement Spoiler tags but I'll take that discussion to the issue linked by dessalines.