lemmy-ui icon indicating copy to clipboard operation
lemmy-ui copied to clipboard

add new themes

Open 2xx04 opened this issue 2 years ago • 9 comments

2xx04 avatar Apr 09 '22 01:04 2xx04

Could you include screenshots for each theme? I see some of them in your lemmy-ui-themes repo, but not all of them. Btw, in the future it might also be nice to include screenshots directly in lemmy-ui to make it easier for users to pick a theme.

Its also worth noting that after this PR, there will be 20 themes included with lemmy-ui, which is a lot. It might be better to limit builtin themes to a more managable number, like 10 or so. But its okay if we merge this first and then consider removing some unpopular themes later.

Nutomic avatar Apr 11 '22 14:04 Nutomic

the lora themes are basically the same (with variants, for an example in compact I hid all avatars and banners), all screenshots are there/

2xx04 avatar Apr 11 '22 18:04 2xx04

When is the next release? none of the themes are tested through a real lemmy install except for winternord. Also darkspace still has missing search background because I haven't added the class to search.tsx yet.

Until I've done so, we shouldn't merge this pull request.

2xx04 avatar Apr 12 '22 01:04 2xx04

closing, for now.

2xx04 avatar Apr 12 '22 01:04 2xx04

FYI you can also mark a pr as draft so it cant be merged (top right, near reviewers).

Nutomic avatar Apr 12 '22 10:04 Nutomic

Oh, I didn't know that. thanks.

2xx04 avatar Apr 12 '22 12:04 2xx04

I've converted it to a draft for you. I'd prefer you bundle all these changes as one testable PR, would make it a lot easier for me.

dessalines avatar Apr 12 '22 17:04 dessalines

How would I do that?

2xx04 avatar Apr 13 '22 04:04 2xx04

You need to add css classes / changes for these themes to work correctly, right? Add those changes to the necessary files, and commit them to this branch.

dessalines avatar Apr 13 '22 17:04 dessalines