lemmy-ui icon indicating copy to clipboard operation
lemmy-ui copied to clipboard

Comment fedilink icon should be hidden if federation is disabled

Open Nutomic opened this issue 2 years ago • 4 comments

Federation is enabled/disabled via config, so federation state is not available in api. Seems like we have to move it to the database to make this work.

Nutomic avatar Mar 28 '22 11:03 Nutomic

It should only show that link if its a non-local domain... could you show an example where its doing that for a local post / comment?

dessalines avatar Mar 28 '22 18:03 dessalines

I changed it in this pr to always show the fedilink, because even for local comments you need that, if you want to fetch the comment from another federated instance.

Nutomic avatar Mar 29 '22 15:03 Nutomic

I'm confused tho, maybe I merged that too hastily. If a comment is local, why should it show that federated link? It should only show that icon if its a federated / non-local comment.

dessalines avatar Mar 29 '22 15:03 dessalines

Imagine you are browsing another Lemmy instance, see an interesting (or controversial) comment, and want to fetch it on your own instance so that you can reply to it. Lets say its a local comment on that instance. If you copy the normal link (.../post/123/comment/456) and paste it into your instance search, there will be no result. You would have to be aware that the /post/123 part needs to be removed, which isnt documented anywhere.

Its much easier to tell people: if you want to fetch a remote post/comment to your instance, take the fedilink, paste it into your instance search, and done.

Nutomic avatar Mar 29 '22 15:03 Nutomic

Can this be closed?

jsit avatar Jun 23 '23 21:06 jsit