lemmy-ui icon indicating copy to clipboard operation
lemmy-ui copied to clipboard

Regression: "Mark post as read when clicking "Expand here" on the preview image on the post listing page" does not work anymore

Open milandamen opened this issue 8 months ago • 0 comments

Requirements

  • [X] This is a bug report, and if not, please post to https://lemmy.ml/c/lemmy_support instead.
  • [X] Please check to see if this issue already exists.
  • [X] It's a single bug. Do not report multiple bugs in one issue.
  • [X] It's a frontend issue, not a backend issue; Otherwise please create an issue on the backend repo instead.

Summary

In https://github.com/LemmyNet/lemmy-ui/pull/1978 a feature was added where if you expand the preview for a post, the post would be marked as read, and when setting "Show read posts" is unchecked, these posts would not show up again on the listing page.

This was a very useful feature if you frequently viewed image posts, where you only need to view the image and not visit the post itself, like for meme posts.

In the current version (0.19.1) this feature is broken, because even after expanding the preview, and refreshing the page, the post is still visible in the listing. I upgraded from 0.18.4 to 0.19.1 today and it stopped working.

When I check the network requests in the browser devtools, there should be a request to the lemmy server for marking the post as read, but no such request is made. The only request made is to load the bigger version of the image.

Steps to Reproduce

  1. Be logged in.
  2. Have the user setting "Show Read Posts" as false.
  3. Open the main listing page (homepage).
  4. Expand the preview of an image post.
  5. Refresh the page (F5, or ctrl+shift+r)
  6. The post is still visible, but it should not be.

Technical Details

lemmy: 0.19.1-rc.2 lemmy-ui: 0.19.1 Browser: Firefox 121.0 OS: Ubuntu 22.04.3 LTS (Kubuntu flavour)

Lemmy Instance Version

0.19.1

Lemmy Instance URL

No response

milandamen avatar Dec 26 '23 17:12 milandamen