lemmy-ui icon indicating copy to clipboard operation
lemmy-ui copied to clipboard

Comment depth

Open SleeplessOne1917 opened this issue 2 years ago • 10 comments

Closes #1069. In addition to making comment threads lists to make them easier to use with screen readers, I also made it easier to track of comment depth visually per a user suggestion. This is what a thread looks like now: image

SleeplessOne1917 avatar Jun 04 '23 04:06 SleeplessOne1917

User that suggested the change here -- thanks for the (very) quick PR! Hoping this gets merged soon.

AgentElement avatar Jun 04 '23 05:06 AgentElement

The issue with an ordered list is that it would cause screen readers to read out a number before each comment, and that doesn't seem to make much sense. It matters that the comment is at depth 2, not that it's the fifth comment in this thread at depth 2. Perhaps someone else disagrees, but I'm struggling to think of a reason I'd ever want to innumerate the order of comments. It's the depth that matters here.

fastfinge avatar Jun 05 '23 12:06 fastfinge

The colored lines seem overkill now. Would you just make them gray / muted? Example:

Screenshot_2023-06-05-11-56-19-832_com rubenmayayo reddit

dessalines avatar Jun 05 '23 15:06 dessalines

Colors seem fine but I would make them lighter or translucent.

Nutomic avatar Jun 05 '23 20:06 Nutomic

An option to click on them to collapse threads would also be good, but then you'd probably want to make them wider.

Kommynct avatar Jun 06 '23 08:06 Kommynct

@Kommynct That's a separate issue. Please keep things on topic, we're juggling many things right now.

dessalines avatar Jun 06 '23 16:06 dessalines

While we're on an accessibility vibe, passing level AA here would be excellent for readability: https://webaim.org/resources/contrastchecker/

nebeker avatar Jun 06 '23 18:06 nebeker

We could have colored vs muted nesting indicators as an option in the settings, leaving them on (colored) by default. I think it's a matter of user preference.

AgentElement avatar Jun 06 '23 22:06 AgentElement

Adding new options is pretty complicated, not a great idea for something so minor.

Nutomic avatar Jun 07 '23 09:06 Nutomic

I think colored is better for visibility, and if you like uncolored lines, I can easily whip up a stylus theme that colors them however you like. If they are uncolored I could probably not make them colored with the selectors.

I think we should prioritize accessibility over aesthetics.

Kommynct avatar Jun 07 '23 09:06 Kommynct

Either way, colored or uncolored is a small difference, and can be addressed later on For now I think the priority should be getting any variation of this PR merged, as there is a big influx of users, many of them laypeople, and whether they stay or leave depends partially on how good the UI & UX is, and this is a small but significant improvement to it.

Junebugging avatar Jun 14 '23 18:06 Junebugging

@Junebugging Now that the big HTTP changes are finally merged into main, I can finish this up.

SleeplessOne1917 avatar Jun 14 '23 23:06 SleeplessOne1917

The comments look like this now.

image

SleeplessOne1917 avatar Jun 15 '23 00:06 SleeplessOne1917

@dessalines @jsit @nebeker If you don't have any more requested changes, please approve.

SleeplessOne1917 avatar Jun 15 '23 01:06 SleeplessOne1917