jerboa icon indicating copy to clipboard operation
jerboa copied to clipboard

Published 20 hours ago • verified publisher icon LemmyNet

Black theme doesn't set the android status bar to black

Open obosob opened this issue 1 year ago • 5 comments

** Jerboa Version ** 0.0.33

Describe the bug When in Black theme the status bar on android, remains the same colour as the background colour in Dark mode, rather than matching the theme.

Screenshot_20230615-035813.png

Screenshot_20230615-035803.png

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Settings > Look and feel'
  2. Click on 'Theme'
  3. Select 'Black'
  4. Observe the status bar

obosob avatar Jun 15 '23 02:06 obosob

I'm going to pick this issue up for my school project. Does any one knows if there is a coding standard available? If there is not i will of course do my best to work as neat as possible.

Schoolkid1 avatar Jun 16 '23 10:06 Schoolkid1

On my phone (Oppo A78) the toolbar does match. Could you tell me what device you are using?

Screenshot_2023-06-16-13-23-11-52_a10f969cf1c4adf2c503042b459b8476

Schoolkid1 avatar Jun 16 '23 11:06 Schoolkid1

@dessalines I am not getting response and after checking on my android phone I concluded the issue doesn't show up. Shall we close this issue?

Schoolkid1 avatar Jun 19 '23 02:06 Schoolkid1

This is on a Google Pixel 6, sorry for late reply.

obosob avatar Jun 19 '23 13:06 obosob

For me this problem is not reproduce-able. In combination with the deadline for my school year I am going to focus on another issue. Maybe some one else wants to pick up this issue?

Schoolkid1 avatar Jun 21 '23 12:06 Schoolkid1

What android version?

MV-GH avatar Jul 25 '23 22:07 MV-GH

It seems the Google Pixel uses a different buildup in the way it shows colors when changing theme, to resolve this issue i added in the Color.kt file an extra value to adjust specifically the toolbar color. I staged the change, can some one check if this value is sufficient to solve this issue?

Schoolkid1 avatar Aug 09 '23 23:08 Schoolkid1

@Schoolkid1 make a PR with your proposed changes

MV-GH avatar Aug 10 '23 05:08 MV-GH

I made a PR. I wanted to split it between #682 and #661 but it combined the files. Can you check if you can acces the pull request. This is my first PR with GitHub so if there are any mistakes I apologise in advance and I am eager to hear feedback to how I can improve.

Schoolkid1 avatar Aug 10 '23 20:08 Schoolkid1

I do not see the PR. Also the reason your changes are combined, is that you did both changes on the same branch.

Take a look at this article: https://docs.github.com/en/get-started/quickstart/contributing-to-projects

And this one for setting upstream as the above does not seem to mention it https://devopscube.com/set-git-upstream-respository-branch/

or this but it's pretty lengthy https://git-scm.com/book/en/v2/GitHub-Contributing-to-a-Project

MV-GH avatar Aug 11 '23 03:08 MV-GH

I do have a link for the PR , it is https://github.com/MV-GH/jerboa/pull/1

But i will delete my fork and reinstall it and do it following the given steps.

Schoolkid1 avatar Aug 11 '23 05:08 Schoolkid1

Be carefully, with deleting your fork, it will also delete your changes. Keep the fork make a new one, until you have it setup as above and recreated your changes their in separate branch. I see that PR but that one is a PR to my fork. You need to do a PR to this repository (upstream). As you can see it has also many conflicts, this is because it is quite behind on changes from upstream. If you have it setup as above it will be very easy to pull the changes from upstream and then merge them into your branches with the changes.

MV-GH avatar Aug 11 '23 05:08 MV-GH

New link to PR https://github.com/dessalines/jerboa/pull/1167

Is this better?

Schoolkid1 avatar Aug 11 '23 06:08 Schoolkid1

Stale issue, and doesn't seem to be an issue.

dessalines avatar Feb 10 '24 22:02 dessalines