jerboa
jerboa copied to clipboard
LemmyNet
Action Bar Buttons get pushed off screen when comment count is too high
** Jerboa Version ** 0.0.34
Describe the bug Action Bar Buttons beneath a post are being pushed off screen when the comment counter gets to high or has too much text alltogether.
To Reproduce
- Open Jerboa
- Open one of the top comments with more then 100 comments
- Check if the more action button is still visible
- It is not (see screenshot)
I have a quick fix for this but its not a pretty one.
What version of Android is that screenshot from?
Android 13 but i can also reproduce this on Android 12
This is about the hamburger menu, isn't it? the three vertical dots (...) because I'm not sure what Action Bar is
Yes exactly those, but it concerns basically all the buttons in this section. In extreme cases all of them will be pushed out of the screen.
Ok, I think I can try to take care of this
On Fri, 16 Jun 2023 at 12:36, Marcus @.***> wrote:
Yes exactly those, but it concerns basically all the buttons in this section. In extreme cases all of them will be pushed out of the screen.
— Reply to this email directly, view it on GitHub https://github.com/dessalines/jerboa/issues/639#issuecomment-1594474232, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABMXYEVY45AJZTSEARPREDXLQZKZANCNFSM6AAAAAAZGGPFKU . You are receiving this because you commented.Message ID: @.***>
@twizmwazin, @MV-GH, @dessalines how do we want to tackle this? Even setting the Arrangement to SpaceAround doesn't leave enough space. We should also decide on a minimum width that we want to cater for, I think 240px is the norm?
It get's especially messy if all the buttons are available
Should we move ActionButtons to the More menu when there isn't enough space?
I am open for changing XXX comments (XXX new) to XXX (+XXX) But only for card layout as list layout does not suffer this problem. I was discussing this in matrix too
Other solutions are probably setting weight on these things and make that text have least weight and make it clip?
Another improvement we can do is remove some of the padding around the icons
I think a flowrow, and maybe smaller margins is probably the best way to handle it. That would safely cover all screen widths by wrapping to new lines.
Maybe we could shorten the word "comments" or even remove it? When removed, the buttons have a lot more space and if the counter rounds (for example like reddit to "12.4k") then the counter doesnt evet take much space.
