jerboa
jerboa copied to clipboard
Add PR template that informs the reader about formatKotlin
Basically title, add a template for pull requests that informs the reader that the reader shouldn't forget to do ./gradlew formatkotlin
Better approach would be to have a pre-commit hook that executes it maybe?
I am not opposed to that either way it should be mentioned in CONTRIBUTING.md
It needs to be documented either way. In my experience even if you have a pre-commit config most users won't use it.
I like the idea of setting up a basic CONTRIBUTING.md, just mentioning this and any other practices/conventions we want to adhere to along the way.
Yes, a contributing doc would be nice
Other things that would be good to mention:
- when to bump the settings database version
- making changes to strings.xml files (to make localisation changes easier to manage)
It needs to be documented either way. In my experience even if you have a pre-commit config most users won't use it.
https://github.com/jeremymailen/kotlinter-gradle#git-hooks
it's possible to force add them on build