jerboa icon indicating copy to clipboard operation
jerboa copied to clipboard

Bash isn't portable, use POSIX sh instead

Open 7heo opened this issue 1 year ago • 2 comments

Also, hardcoding bash to /bin/bash is even less portable.

In addition, I commented an unused variable (name not present anywhere in the code base, not exported).

7heo avatar Jun 12 '23 09:06 7heo

Why comment the unused variable? If truly unused removal should be okay. Commenting implicates that it might be relevant in certain conditions which might lead other devs to search for the "when is it relevant".

datWeazel avatar Jun 12 '23 12:06 datWeazel

Why comment the unused variable? If truly unused removal should be okay.

I am not the original author of this script, it's not for me to decide. Maybe they will remember what they wanted to do with it and finish it. If I remove it, they might forget entirely.

7heo avatar Jun 12 '23 12:06 7heo

I say just remove it, I don't think there was some larger intent here.

twizmwazin avatar Jun 12 '23 21:06 twizmwazin

I mean, anyway, @dessalines wrote that line according to the git blame, so he will say something if it's meant to stay.

7heo avatar Jun 12 '23 22:06 7heo