jerboa
jerboa copied to clipboard
Bash isn't portable, use POSIX sh instead
Also, hardcoding bash to /bin/bash is even less portable.
In addition, I commented an unused variable (name not present anywhere in the code base, not exported).
Why comment the unused variable? If truly unused removal should be okay. Commenting implicates that it might be relevant in certain conditions which might lead other devs to search for the "when is it relevant".
Why comment the unused variable? If truly unused removal should be okay.
I am not the original author of this script, it's not for me to decide. Maybe they will remember what they wanted to do with it and finish it. If I remove it, they might forget entirely.
I say just remove it, I don't think there was some larger intent here.
I mean, anyway, @dessalines wrote that line according to the git blame, so he will say something if it's meant to stay.